From owner-freebsd-numerics@FreeBSD.ORG Sun Aug 12 22:57:56 2012 Return-Path: Delivered-To: freebsd-numerics@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9F2751065674 for ; Sun, 12 Aug 2012 22:57:56 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194]) by mx1.freebsd.org (Postfix) with ESMTP id 382948FC0C for ; Sun, 12 Aug 2012 22:57:56 +0000 (UTC) Received: from server.rulingia.com (c220-239-249-137.belrs5.nsw.optusnet.com.au [220.239.249.137]) by vps.rulingia.com (8.14.5/8.14.5) with ESMTP id q7CMvuMB075510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 08:57:56 +1000 (EST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.14.5/8.14.5) with ESMTP id q7CMvn5v020899 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 13 Aug 2012 08:57:49 +1000 (EST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.14.5/8.14.5/Submit) id q7CMvnlu020898 for freebsd-numerics@freebsd.org; Mon, 13 Aug 2012 08:57:49 +1000 (EST) (envelope-from peter) Resent-From: Peter Jeremy Resent-Date: Mon, 13 Aug 2012 08:57:49 +1000 Resent-Message-ID: <20120812225749.GJ20453@server.rulingia.com> Resent-To: freebsd-numerics@freebsd.org Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194]) by server.rulingia.com (8.14.5/8.14.5) with ESMTP id q6I1gtMU089283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Jul 2012 11:42:56 +1000 (EST) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by vps.rulingia.com (8.14.5/8.14.5) with ESMTP id q6I1gra8070895 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 18 Jul 2012 11:42:54 +1000 (EST) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.5/8.14.5) with ESMTP id q6I1gpWl095622; Tue, 17 Jul 2012 18:42:51 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.5/8.14.5/Submit) id q6I1goO4095621; Tue, 17 Jul 2012 18:42:50 -0700 (PDT) (envelope-from sgk) From: Steve Kargl Mail-Followup-To: freebsd-numerics@freebsd.org To: Peter Jeremy Message-ID: <20120718014250.GA95603@troutmask.apl.washington.edu> References: <20120714120432.GA70706@server.rulingia.com> <20120717084457.U3890@besplex.bde.org> <5004A5C7.1040405@missouri.edu> <5004DEA9.1050001@missouri.edu> <20120717040118.GA86840@troutmask.apl.washington.edu> <20120717042125.GF66913@server.rulingia.com> <20120717043848.GB87001@troutmask.apl.washington.edu> <20120717225328.GA86902@server.rulingia.com> <20120717232740.GA95026@troutmask.apl.washington.edu> <20120718001337.GA87817@server.rulingia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120718001337.GA87817@server.rulingia.com> User-Agent: Mutt/1.4.2.3i Cc: Diane Bruce , John Baldwin , David Chisnall , Stephen Montgomery-Smith , Bruce Evans , Bruce Evans , David Schultz , Warner Losh Subject: Re: Use of C99 extra long double math functions after r236148 X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 12 Aug 2012 22:57:56 -0000 X-Original-Date: Tue, 17 Jul 2012 18:42:50 -0700 X-List-Received-Date: Sun, 12 Aug 2012 22:57:56 -0000 On Wed, Jul 18, 2012 at 10:13:37AM +1000, Peter Jeremy wrote: > On 2012-Jul-17 16:27:40 -0700, Steve Kargl wrote: > >I won't have time to go over the code in detail until > >this weekend, but a quick peek showed some issues. The > >first is style. Although fdlibm has a rather interest > >coding style, new code should use KNF. > > I hope that was only the function declaration lines. I think > the rest is KNF. Comments were wrong, too. > >I think you're missing a sign. Let z = x + i*y. > >Then, i*z = i*x+i*i*y = -y + i*x, yielding > > Yes, I think you're right in both cases. I wasn't thinking clearly. > (Something to automatically generate this sort of code would mean you > only need to write it once). > > Try the attached (also at http://www.rulingia.com/~peter/catan.c ). > And I'm aware it has UTF-8 in the comments. I can't quickly find > anything on character sets in style(9) and would apppreciate a > ruling on it. I doubt style(9) says anything about UTF-8 as style(9) has been around a long time. Can you inline the code after your sig? It is easier to review and comment on; otherwise, I have to save the attachment, open it in a window, and copy-n-paste. It amy also be prudent to start a new thread as this subthread may get lost. The question is where. I'm not subscribed to hackers and Bruce is not subscribed to current. -- Steve