Date: Sun, 12 Aug 2012 22:57:56 -0000 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Peter Jeremy <peter@rulingia.com> Cc: Diane Bruce <db@db.net>, John Baldwin <jhb@freebsd.org>, David Chisnall <theraven@freebsd.org>, Stephen Montgomery-Smith <stephen@missouri.edu>, Bruce Evans <bde@freebsd.org>, Bruce Evans <brde@optusnet.com.au>, David Schultz <das@freebsd.org>, Warner Losh <imp@bsdimp.com> Subject: Re: Use of C99 extra long double math functions after r236148 Message-ID: <20120718014250.GA95603@troutmask.apl.washington.edu> Resent-Message-ID: <20120812225749.GJ20453@server.rulingia.com> In-Reply-To: <20120718001337.GA87817@server.rulingia.com> References: <20120714120432.GA70706@server.rulingia.com> <20120717084457.U3890@besplex.bde.org> <5004A5C7.1040405@missouri.edu> <5004DEA9.1050001@missouri.edu> <20120717040118.GA86840@troutmask.apl.washington.edu> <20120717042125.GF66913@server.rulingia.com> <20120717043848.GB87001@troutmask.apl.washington.edu> <20120717225328.GA86902@server.rulingia.com> <20120717232740.GA95026@troutmask.apl.washington.edu> <20120718001337.GA87817@server.rulingia.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 18, 2012 at 10:13:37AM +1000, Peter Jeremy wrote: > On 2012-Jul-17 16:27:40 -0700, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote: > >I won't have time to go over the code in detail until > >this weekend, but a quick peek showed some issues. The > >first is style. Although fdlibm has a rather interest > >coding style, new code should use KNF. > > I hope that was only the function declaration lines. I think > the rest is KNF. Comments were wrong, too. > >I think you're missing a sign. Let z = x + i*y. > >Then, i*z = i*x+i*i*y = -y + i*x, yielding > > Yes, I think you're right in both cases. I wasn't thinking clearly. > (Something to automatically generate this sort of code would mean you > only need to write it once). > > Try the attached (also at http://www.rulingia.com/~peter/catan.c ). > And I'm aware it has UTF-8 in the comments. I can't quickly find > anything on character sets in style(9) and would apppreciate a > ruling on it. I doubt style(9) says anything about UTF-8 as style(9) has been around a long time. Can you inline the code after your sig? It is easier to review and comment on; otherwise, I have to save the attachment, open it in a window, and copy-n-paste. It amy also be prudent to start a new thread as this subthread may get lost. The question is where. I'm not subscribed to hackers and Bruce is not subscribed to current. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120718014250.GA95603>