From owner-freebsd-rc@FreeBSD.ORG  Sat Oct 27 18:06:30 2012
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 929C5A87;
 Sat, 27 Oct 2012 18:06:30 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id E61E38FC12;
 Sat, 27 Oct 2012 18:06:29 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id jf20so1626820bkc.13
 for <multiple recipients>; Sat, 27 Oct 2012 11:06:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc:content-type;
 bh=tyvkaCmm0Hdiy5RO/Gn8k7tbvvGGe5Y13CkFbaEi6so=;
 b=E3LHCpe+Qfqmlxwtemx1/mIIdAkgF8uDQ9EK24Tf8hGelE7KTEORVrZlzmeAMlWCaU
 uoH/v3qSgr0myBKqF2Gk3qfa1HWylfjEFKMHISX8CJORbgX93kiQazoU0IdN0wCHlqRC
 Dia73EEmU6AHG8grzHBeevcS6KV/wvDS5xcyQg+y1kyjvXGsj8C9Na/sblZD5PJEZ3G2
 3UHWVIitFCBDYSCTx1l9F9viqdBI8UCGdyIn63frkrMCFdaNZHLWJxF6AD9P46bMDOcK
 tA1Ft3Zl1HUGi847A5PBQRrK2P2QTB5U59jPVBDUXZmHeyXt02TTrhmTebaJnLKCcrf1
 LGLQ==
Received: by 10.204.7.213 with SMTP id e21mr7837815bke.32.1351361189062; Sat,
 27 Oct 2012 11:06:29 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.204.50.197 with HTTP; Sat, 27 Oct 2012 11:05:57 -0700 (PDT)
In-Reply-To: <20121028.025506.866731529487557055.hrs@allbsd.org>
References: <CADLo839FSPGTHM58+fJBwEVUZ+gxTyXOqJffOrVyPr5k7xaqtw@mail.gmail.com>
 <20121028.021752.529031225588915529.hrs@allbsd.org>
 <CADLo83-=3PGEQtfQDHPCO30eJYWGLE=xbR8U9WuJMygRvDRNFg@mail.gmail.com>
 <20121028.025506.866731529487557055.hrs@allbsd.org>
From: Chris Rees <utisoft@gmail.com>
Date: Sat, 27 Oct 2012 19:05:57 +0100
Message-ID: <CADLo8398tTHDXr9va31_Fk=Md9Kt63HQzVF1Kj00fTwccKHxNw@mail.gmail.com>
Subject: Re: Spaces in ${name}_chroot
To: Hiroki Sato <hrs@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-rc@freebsd.org
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
 <freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
 <mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2012 18:06:30 -0000

On 27 October 2012 18:55, Hiroki Sato <hrs@freebsd.org> wrote:
> Chris Rees <utisoft@gmail.com> wrote
>   in <CADLo83-=3PGEQtfQDHPCO30eJYWGLE=xbR8U9WuJMygRvDRNFg@mail.gmail.com>:
>
> ut> On 27 October 2012 18:17, Hiroki Sato <hrs@freebsd.org> wrote:
> ut> > Chris Rees <utisoft@gmail.com> wrote
> ut> >   in <CADLo839FSPGTHM58+fJBwEVUZ+gxTyXOqJffOrVyPr5k7xaqtw@mail.gmail.com>:
> ut> >
> ut> > ut> Hi all,
> ut> > ut>
> ut> > ut> A guy in IRC pointed out to me that rc.subr will not work correctly if
> ut> > ut> a chroot has spaces in it.
> ut> > ut>
> ut> > ut> Although this is unlikely, would it hurt to include it?  Lacking a src
> ut> > ut> bit someone may need to put their name to it, but I'm happy to commit
> ut> > ut> & handle MFCs.
> ut> > ut>
> ut> > ut> Chris
> ut> > ut>
> ut> > ut> [1] http://www.bayofrum.net/~crees/patches/rc-subr-support-chroot-spaces.diff
> ut> >
> ut> >  I think this patch is correct.  Please go ahead.
> ut>
> ut> Should I give it 1 month MFC, or leave it in head?
>
>  I think this can be merged safely.  Let's see if something goes wrong
>  with this patch in head for a while.

It's in, thank you.

Chris