Date: Sat, 27 Oct 2012 19:05:57 +0100
From: Chris Rees <utisoft@gmail.com>
To: Hiroki Sato <hrs@freebsd.org>
Cc: freebsd-rc@freebsd.org
Subject: Re: Spaces in ${name}_chroot
Message-ID: <CADLo8398tTHDXr9va31_Fk=Md9Kt63HQzVF1Kj00fTwccKHxNw@mail.gmail.com>
In-Reply-To: <20121028.025506.866731529487557055.hrs@allbsd.org>
References: <CADLo839FSPGTHM58%2BfJBwEVUZ%2BgxTyXOqJffOrVyPr5k7xaqtw@mail.gmail.com> <20121028.021752.529031225588915529.hrs@allbsd.org> <CADLo83-=3PGEQtfQDHPCO30eJYWGLE=xbR8U9WuJMygRvDRNFg@mail.gmail.com> <20121028.025506.866731529487557055.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 October 2012 18:55, Hiroki Sato <hrs@freebsd.org> wrote: > Chris Rees <utisoft@gmail.com> wrote > in <CADLo83-=3PGEQtfQDHPCO30eJYWGLE=xbR8U9WuJMygRvDRNFg@mail.gmail.com>: > > ut> On 27 October 2012 18:17, Hiroki Sato <hrs@freebsd.org> wrote: > ut> > Chris Rees <utisoft@gmail.com> wrote > ut> > in <CADLo839FSPGTHM58+fJBwEVUZ+gxTyXOqJffOrVyPr5k7xaqtw@mail.gmail.com>: > ut> > > ut> > ut> Hi all, > ut> > ut> > ut> > ut> A guy in IRC pointed out to me that rc.subr will not work correctly if > ut> > ut> a chroot has spaces in it. > ut> > ut> > ut> > ut> Although this is unlikely, would it hurt to include it? Lacking a src > ut> > ut> bit someone may need to put their name to it, but I'm happy to commit > ut> > ut> & handle MFCs. > ut> > ut> > ut> > ut> Chris > ut> > ut> > ut> > ut> [1] http://www.bayofrum.net/~crees/patches/rc-subr-support-chroot-spaces.diff > ut> > > ut> > I think this patch is correct. Please go ahead. > ut> > ut> Should I give it 1 month MFC, or leave it in head? > > I think this can be merged safely. Let's see if something goes wrong > with this patch in head for a while. It's in, thank you. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo8398tTHDXr9va31_Fk=Md9Kt63HQzVF1Kj00fTwccKHxNw>