From owner-freebsd-current@freebsd.org Fri Dec 30 20:40:40 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B7EBC987DF for ; Fri, 30 Dec 2016 20:40:40 +0000 (UTC) (envelope-from tsoome@me.com) Received: from st13p35im-asmtp004.me.com (st13p35im-asmtp004.me.com [17.164.199.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 53B8A194E; Fri, 30 Dec 2016 20:40:40 +0000 (UTC) (envelope-from tsoome@me.com) Received: from process-dkim-sign-daemon.st13p35im-asmtp004.me.com by st13p35im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OJ000G00JHYTH00@st13p35im-asmtp004.me.com>; Fri, 30 Dec 2016 19:40:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=4d515a; t=1483126833; bh=wo27C4d6IeYg5x4rXfhohPWrap5+Gvz0+s0gedQchco=; h=Content-type:MIME-version:Subject:From:Date:Message-id:To; b=TFLqqvT+cFmdWLFt72U8tEw8EUqJMuV2mCjNQ1HkrlkFTbQwIB8RpCPCu7ks70eVT 8nZ6O/saISRaa31mzoO6vCq7LUyUdlBG4cytQSLABC3qtBZP6aM6ha5+TjdaC+8t8q hVkMZuIekSgrX26ehhgROimGQl0oKe5LxX2dNSPTRv1KD7+mB63zrokOX4PDqrUqp/ qbqVSnKujJsslRQqWv+Q8EJqDE/we3ZAdOH8THmEDJH0Wq//TG11seQE4preLmfSSj vOGZEE/pau6sCvwU++Kg7SokMGUs7dhGcgvhcPwsSEOzWpjfZS9G6J59A8jH7VeORs KuNVhLikG7dfw== Received: from nazgul.lan (220-90-235-80.dyn.estpak.ee [80.235.90.220]) by st13p35im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OJ0002I4JZGIP10@st13p35im-asmtp004.me.com>; Fri, 30 Dec 2016 19:40:33 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-30_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1612300307 Content-type: text/plain; charset=utf-8 MIME-version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: r 310850: buildworld failure due to: nandfs.c:1049:15: error: too many arguments to function call, From: Toomas Soome In-reply-to: <30C71053-94F3-44D1-9089-CE31E67912DF@FreeBSD.org> Date: Fri, 30 Dec 2016 21:40:27 +0200 Cc: "O. Hartmann" , FreeBSD CURRENT , Toomas Soome Content-transfer-encoding: quoted-printable Message-id: References: <20161230202338.73e7d00b@thor.walstatt.dynvpn.de> <30C71053-94F3-44D1-9089-CE31E67912DF@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3259) X-Mailman-Approved-At: Fri, 30 Dec 2016 20:49:59 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2016 20:40:40 -0000 > On 30. dets 2016, at 21:35, Dimitry Andric wrote: >=20 > On 30 Dec 2016, at 20:23, O. Hartmann wrote: >>=20 >> Recent update of CURRENT to 2310850 fails with buildworld error: >>=20 >> [...] >> =3D=3D=3D> lib/atf/libatf-c++ (all) >> --- all_subdir_lib/libstand --- >> --- nandfs.o --- >> /usr/src/lib/libstand/nandfs.c:1049:15: error: too many arguments to = function call, >> expected 6, have 7 buffer, NULL); >> ^~~~ >> /usr/obj/usr/src/tmp/usr/include/sys/_null.h:32:14: note: expanded = from macro 'NULL' >> #define NULL ((void *)0) >> ^~~~~~~~~~~ >> 1 error generated. >> *** [nandfs.o] Error code 1 >=20 > This looks like the culprit to me: >=20 > On 30 Dec 2016, at 20:06, Toomas Soome wrote: >> Author: tsoome >> Date: Fri Dec 30 19:06:29 2016 >> New Revision: 310850 >> URL: https://svnweb.freebsd.org/changeset/base/310850 >>=20 >> Log: >> dosfs support in libstand is broken since r298230 >>=20 >> Apparently the libstand dosfs optimization is a bit too optimistic >> and did introduce possible memory corruption. >>=20 >> This patch is backing out the bad part and since this results in >> dosfs reading full blocks now, we can also remove extra offset = argument >> from dv_strategy callback. >>=20 >> The analysis of the issue and the backout patch is provided by = Mikhail Kupchik. >>=20 >> PR: 214423 >> Submitted by: Mikhail Kupchik >> Reported by: Mikhail Kupchik >> Reviewed by: bapt, allanjude >> Approved by: allanjude (mentor) >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D864 >=20 > For some reason, your build seems to pick up an older stand.h header? >=20 > -Dimitry >=20 oh, apparently I *still* did miss one strategy call in nandfs.. Sorry, = I=E2=80=99ll try to fix it asap. rgds, toomas