From owner-freebsd-arch Thu Jan 31 20:46:23 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id DEBF937B404 for ; Thu, 31 Jan 2002 20:46:19 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id g114kCi113676; Thu, 31 Jan 2002 23:46:12 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020131.200942.41874592.imp@village.org> References: <20020131.200942.41874592.imp@village.org> Date: Thu, 31 Jan 2002 23:46:11 -0500 To: "M. Warner Losh" , arch@FreeBSD.ORG From: Garance A Drosihn Subject: Re: Bin diffs Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 8:09 PM -0700 1/31/02, M. Warner Losh wrote: >OK. Here's my first round of diffs. > [...] > >o Some general fussiness that I couldn't help myself on. > >Comments? In the area of generally fussiness... You can't necessarily see it in the diff, but the prototype sections in different files have different ideas for tabbing. For instance, the new prototypes in +++ cat/cat.c +static void raw_cat(int); (ie, no tabs at all) +++ chio/chio.c +static void cleanup(void); (first word, , remainder of prototype) +++ dd/args.c +static int c_arg(const void *, const void *); (all words describing the return value, , remainder) -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message