From owner-svn-src-head@freebsd.org Wed Mar 23 01:50:34 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03C30A92D23 for ; Wed, 23 Mar 2016 01:50:34 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D76CD160F for ; Wed, 23 Mar 2016 01:50:33 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: a411e973-f099-11e5-b278-7d22021d92d7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Wed, 23 Mar 2016 01:50:37 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u2N1oPpT012672; Tue, 22 Mar 2016 19:50:25 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1458697825.1091.28.camel@freebsd.org> Subject: Re: svn commit: r297190 - head/sys/kern From: Ian Lepore To: Warner Losh , Rick Macklem Cc: Edward Tomasz Napierala , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Date: Tue, 22 Mar 2016 19:50:25 -0600 In-Reply-To: References: <201603221346.u2MDk1XH029623@repo.freebsd.org> <1458662141.1091.16.camel@freebsd.org> <1614105839.27686393.1458695637184.JavaMail.zimbra@uoguelph.ca> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 01:50:34 -0000 On Tue, 2016-03-22 at 19:28 -0600, Warner Losh wrote: > On Tue, Mar 22, 2016 at 7:13 PM, Rick Macklem > wrote: > > > Ian Lepore wrote: > > > On Tue, 2016-03-22 at 13:46 +0000, Edward Tomasz Napierala wrote: > > > > Author: trasz > > > > Date: Tue Mar 22 13:46:01 2016 > > > > New Revision: 297190 > > > > URL: https://svnweb.freebsd.org/changeset/base/297190 > > > > > > > > Log: > > > > Wait for root mount tokens before showing the root mount > > > > prompt. > > > > This restores the pre-r290196 behaviour, eliminating the need > > > > to > > manually > > > > press '.' a couple of times to get USB to finish probing. > > > > > > > > Note that there's still something wrong with the console > > > > (character > > > > echoing doesn't quite work), and there's also a reported > > > > problem with > > > > BHyVe, but those two don't seem related to the problem above. > > > > > > Just a datapoint on the echoing... it works fine on a serial > > > console, > > > it's been years since I've seen glitches at the mountroot prompt. > > > So > > > the problem may be in vt or kbdmux. > > > > > When I had a console character echo problem (not serial), changing > > the > > clock source to RTC fixed it. > > > > I fixed this for the UART code a while ago in r260890. Maybe a > similar fix > is needed here? Basically, is the data being consumed by the > interrupt > handler before we can poll-read it... > > Warner Your cngrab fixes were only for uart? Or was it some other fix? -- Ian