From owner-freebsd-hackers  Sat Sep  1  4:42:23 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id F32D837B409; Sat,  1 Sep 2001 04:42:16 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id VAA19746;
	Sat, 1 Sep 2001 21:41:29 +1000
Date: Sat, 1 Sep 2001 21:41:16 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@besplex.bde.org>
To: <Tor.Egge@fast.no>
Cc: <mb@imp.ch>, <bkarp@icsi.berkeley.edu>, <kpielorz@tdx.co.uk>,
	<sthaug@nethelp.no>, <atrn@zeta.org.au>, <roberto@eurocontrol.fr>,
	<drussell@saturn-tech.com>, <phk@FreeBSD.ORG>,
	<Patrick.Guelat@imp.ch>, <freebsd-hackers@FreeBSD.ORG>,
	<freebsd-smp@FreeBSD.ORG>
Subject: Re: Clock speedup on 4.X FreeBSD SMP and serverworks chipset
In-Reply-To: <200108311939.VAA35839@midten.fast.no>
Message-ID: <20010901213614.I1924-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

On Fri, 31 Aug 2001 Tor.Egge@fast.no wrote:

> > I see (amost).
> >
> > Please format the macro the same as the other macros in the file.
>
> Index: apic_vector.s
> ===================================================================
> RCS file: /home/ncvs/src/sys/i386/isa/apic_vector.s,v
> retrieving revision 1.47.2.4
> diff -u -r1.47.2.4 apic_vector.s
> --- apic_vector.s	18 Jul 2000 21:12:41 -0000	1.47.2.4
> +++ apic_vector.s	31 Aug 2001 19:24:24 -0000
> @@ -653,7 +707,14 @@
>  	FAST_INTR(21,fastintr21)
>  	FAST_INTR(22,fastintr22)
>  	FAST_INTR(23,fastintr23)
> -#define	CLKINTR_PENDING	movl $1,CNAME(clkintr_pending)
> +
> +#define	CLKINTR_PENDING							\
> +	pushl $clock_lock;						\
> +	call s_lock;							\
> +	movl $1,CNAME(clkintr_pending);					\
> +	call s_unlock;							\
> +	addl $4, %esp
> +
>  	INTR(0,intr0, CLKINTR_PENDING)
>  	INTR(1,intr1,)
>  	INTR(2,intr2,)
>

The other macros also have a space befor the semicolons :).  Otherwise OK.
Better commit this (especially to 4.4R) until we have something better.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message