From owner-svn-src-all@FreeBSD.ORG  Tue Mar  9 12:10:00 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 52930106564A;
	Tue,  9 Mar 2010 12:10:00 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from sippysoft.com (gk1.360sip.com [72.236.70.240])
	by mx1.freebsd.org (Postfix) with ESMTP id F25518FC0C;
	Tue,  9 Mar 2010 12:09:59 +0000 (UTC)
Received: from [192.168.1.38] (S0106005004e13421.vs.shawcable.net
	[70.71.175.212]) (authenticated bits=0)
	by sippysoft.com (8.14.3/8.14.3) with ESMTP id o29C9uZx008204
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 9 Mar 2010 04:09:58 -0800 (PST)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <4B963A97.4040308@FreeBSD.org>
Date: Tue, 09 Mar 2010 04:09:59 -0800
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Sippy Software, Inc.
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
References: <58991.1268134136@critter.freebsd.dk>
In-Reply-To: <58991.1268134136@critter.freebsd.dk>
Content-Type: text/plain; charset=KOI8-U; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r204909 - head/sbin/newfs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Mar 2010 12:10:00 -0000

Poul-Henning Kamp wrote:
> In message <201003091031.o29AV3JO088200@svn.freebsd.org>, Maxim Sobolev writes:
> 
>> Log:
>>  Change secrorsize back to int, since that's the data type expected by the
>>  ioctl(DIOCGSECTORSIZE). It creates issues on some architectures.
> 
> Uhm, no, DIOCGSECTORSIZE requires an u_int:
> 
> 	$ grep DIOCGSECTORSIZE /sys/sys/disk.h
> 	#define DIOCGSECTORSIZE _IOR('d', 128, u_int)

Heh, so it was a bug in the original code prior to my initial change. 
However, I guess it's not a big issue anyway since media with sector 
size larger that 2GiB hardly makes any sense today. Maybe in 100 years 
from now this will be regular sector size, but by then we will probably 
have 1024-bit wide ints anyway. :)

-Maxim