Date: Mon, 27 Mar 2023 23:54:39 GMT From: Rick Macklem <rmacklem@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 1512579adcf3 - main - nfscl: Make coverity happy Message-ID: <202303272354.32RNsdQ8095765@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=1512579adcf3a2dee3f13efd702204c1390ccea7 commit 1512579adcf3a2dee3f13efd702204c1390ccea7 Author: Rick Macklem <rmacklem@FreeBSD.org> AuthorDate: 2023-03-27 23:53:30 +0000 Commit: Rick Macklem <rmacklem@FreeBSD.org> CommitDate: 2023-03-27 23:53:30 +0000 nfscl: Make coverity happy Coverity does not like code that checks a function's return value sometimes. Add "(void)" in front of the function when the return value does not matter to try and make it happy. Reported by: emaste MFC after: 3 months --- sys/fs/nfsclient/nfs_clrpcops.c | 2 +- sys/fs/nfsclient/nfs_clvnops.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/fs/nfsclient/nfs_clrpcops.c b/sys/fs/nfsclient/nfs_clrpcops.c index 559bf8646625..9a8e7436f620 100644 --- a/sys/fs/nfsclient/nfs_clrpcops.c +++ b/sys/fs/nfsclient/nfs_clrpcops.c @@ -9245,7 +9245,7 @@ nfscl_statfs(struct vnode *vp, struct ucred *cred, NFSPROC_T *td) error = nfsrpc_statfs(vp, &sb, &fs, &lease, cred, td, &nfsva, &attrflag); if (attrflag != 0) - nfscl_loadattrcache(&vp, &nfsva, NULL, 0, 1); + (void) nfscl_loadattrcache(&vp, &nfsva, NULL, 0, 1); if (error == 0) { NFSLOCKCLSTATE(); if (nmp->nm_clp != NULL) diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnops.c index 39409852e86f..ea493e668dc2 100644 --- a/sys/fs/nfsclient/nfs_clvnops.c +++ b/sys/fs/nfsclient/nfs_clvnops.c @@ -4542,7 +4542,7 @@ nfs_pathconf(struct vop_pathconf_args *ap) NFSV4CONTENT_HOLE, td->td_ucred, &nfsva, &attrflag); if (attrflag != 0) - nfscl_loadattrcache(&vp, &nfsva, + (void) nfscl_loadattrcache(&vp, &nfsva, NULL, 0, 1); mtx_lock(&nmp->nm_mtx); if (error == NFSERR_NOTSUPP)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303272354.32RNsdQ8095765>