From owner-svn-src-head@freebsd.org  Tue Aug  4 08:56:51 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A9A79B3078;
 Tue,  4 Aug 2015 08:56:51 +0000 (UTC)
 (envelope-from etnapierala@gmail.com)
Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com
 [IPv6:2a00:1450:400c:c05::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B10A62F;
 Tue,  4 Aug 2015 08:56:50 +0000 (UTC)
 (envelope-from etnapierala@gmail.com)
Received: by wibud3 with SMTP id ud3so14035590wib.0;
 Tue, 04 Aug 2015 01:56:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:mail-followup-to
 :references:mime-version:content-type:content-disposition
 :in-reply-to:user-agent;
 bh=ARhHsvyOioSCrfo8q1C7eAP/ozGUYp8/CCP41O1pzGY=;
 b=gmy40PVNmQSUTVXvX8AIhxmhj874v7iLPmukagSfq/NgBeZ1Y1a7StKG7qbEO75aAr
 CYnDLYZA/C6f814J4XNG8mndTD7zkWuVhxqWoKja/LOOKLyokCmu/Cm6TCZJuMzTtyM8
 gZ8DXMDe2tDFr7opQW2Bt8QNZPkBmM6J7vcVKLD/4V6fuP8lNvhtcfQe8NJ33+Ldm7Oz
 TUvgsGnwWjGeppv/OjK3roCmM539efj5hL7472XZNM3sgTw6AsnK35ubHqJMp6eM6cM1
 vthqcF4aV3ukM4J7CK/Mc0OB0nYMeL8UZtVCRVxQDy4563OgIfxc4cjv0LpvRo7x7KUy
 3QQA==
X-Received: by 10.180.211.10 with SMTP id my10mr5619963wic.41.1438678608974;
 Tue, 04 Aug 2015 01:56:48 -0700 (PDT)
Received: from brick.home (ess151.neoplus.adsl.tpnet.pl. [83.20.138.151])
 by smtp.gmail.com with ESMTPSA id 4sm627781wjt.46.2015.08.04.01.56.47
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 04 Aug 2015 01:56:48 -0700 (PDT)
Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= <etnapierala@gmail.com>
Date: Tue, 4 Aug 2015 10:56:45 +0200
From: Edward Tomasz Napierala <trasz@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Benjamin Kaduk <bjkfbsd@gmail.com>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r286236 - head/share/man/man9
Message-ID: <20150804085645.GA9407@brick.home>
Mail-Followup-To: Konstantin Belousov <kostikbel@gmail.com>,
 Benjamin Kaduk <bjkfbsd@gmail.com>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
References: <201508031630.t73GUmBR092976@repo.freebsd.org>
 <CAJ5_RoDy=zxpuL8qZQM04EEaRAd_hfjDTyqeYaq6nZmvS5w+Vg@mail.gmail.com>
 <20150804041650.GG2072@kib.kiev.ua>
 <20150804042410.GH2072@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150804042410.GH2072@kib.kiev.ua>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Aug 2015 08:56:51 -0000

On 0804T0724, Konstantin Belousov wrote:
> On Tue, Aug 04, 2015 at 07:16:50AM +0300, Konstantin Belousov wrote:
> > On Mon, Aug 03, 2015 at 01:52:46PM -0400, Benjamin Kaduk wrote:
> > > On Mon, Aug 3, 2015 at 12:30 PM, Edward Tomasz Napierala <trasz@freebsd.org>
> > > wrote:
> > > 
> > > > Author: trasz
> > > > Date: Mon Aug  3 16:30:47 2015
> > > > New Revision: 286236
> > > > URL: https://svnweb.freebsd.org/changeset/base/286236
> > > >
> > > > Log:
> > > >   Document vgonel(9).
> > > >
> > > 
> > > Er, isn't this a step backwards?
> > > 
> > > % static void     vgonel(struct vnode *);
> > > 
> > > It is only accidental that anything outside vfs_subr.c can call vgonel().
> > Indeed, only kernel modules on some architectures could use a hole in
> > the kernel linker to reference vgonel(). The kernel itself cannot call
> > vgonel() outside vfs_subr.c. There is no point in putting vgonel(9) in
> > the man page.
> 
> I believe the source of the confusion is the vgonel() definition, which
> lacks the static qualifier.  I propose to remove vgonel(9) reference from
> the man page and add static to definition.

Done.

> Might be, a review of all functions in vfs_*.c and fixing their missed
> qualifiers would be useful.

Would be nice if clang warned about this case.  No idea why it doesn't.