From owner-svn-ports-head@freebsd.org  Mon Jan 25 09:50:25 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8504A45156;
 Mon, 25 Jan 2016 09:50:25 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BE31FB41;
 Mon, 25 Jan 2016 09:50:24 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from [192.168.1.21] (248.Red-83-39-200.dynamicIP.rima-tde.net
 [83.39.200.248])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id C6E2A43B90;
 Mon, 25 Jan 2016 03:50:15 -0600 (CST)
Subject: Re: svn commit: r406930 - head/archivers/file-roller
To: Alexey Dokuchaev <danfe@FreeBSD.org>
References: <201601221319.u0MDJbbm075196@repo.freebsd.org>
 <20160125085654.GB95732@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Reply-To: marino@freebsd.org
From: John Marino <freebsd.contact@marino.st>
Message-ID: <56A5EFD5.8080804@marino.st>
Date: Mon, 25 Jan 2016 10:50:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160125085654.GB95732@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jan 2016 09:50:26 -0000

On 1/25/2016 9:56 AM, Alexey Dokuchaev wrote:
> On Fri, Jan 22, 2016 at 01:19:37PM +0000, John Marino wrote:
>> New Revision: 406930
>> URL: https://svnweb.freebsd.org/changeset/ports/406930
>>
>> Log:
>>   archivers/file_roller: Fix ambiguous RUN_DEPENDS
>>   
>>   file_roller requires the ports version of unzip (I'm assuming based on
>>   makefile's specifications).  However, since the full path to unzip
>>   was not specified, the base unzip satifies the requirement which results
>>   in the archivers/unzip package not being registered as a run dependency.
>>  
>> [...]
>>  RUN_DEPENDS=	gtar:${PORTSDIR}/archivers/gtar \
>> -    		unzip:${PORTSDIR}/archivers/unzip
>> +    		zipinfo:${PORTSDIR}/archivers/unzip
>> +
>> +# Port unzip is desired, but specify the uniquely named zipinfo to ensure
>> +# archivers/unzip is pulled in.  Using "unzip" is satisfied by base unzip
> 
> Another option would be to specify full path of unzip(1), i.e.
> ${LOCALBASE}/bin/unzip:...  This would also reflect the reality, since if
> base unzip(1) is not sufficient beyond trivial usecases (which is probably
> the reason why `archivers/file-roller' wants "real" unzip -- e.g. the one
> that support encrypted archives and stuff).

zipinfo is a symbolic link to $LOCALBASE/bin/unzip, so I used it to
minimize the change.  I saw the two as equal and thus "dealer's choice"
and I chose the latter.

> You've also introduced trailing whitespace there (in addition to the one in
> pkg-descr, existing prior to this commit).

oops.