Date: Mon, 13 Jun 2022 09:23:29 +0200 From: Stefan Esser <se@FreeBSD.org> To: Damjan Jovanovic <damjan.jov@gmail.com>, Larry Rosenman <ler@freebsd.org> Cc: Freebsd ports <freebsd-ports@freebsd.org>, Developers <developers@freebsd.org> Subject: Re: sysutils/lsof: help! Message-ID: <4d365115-5996-8668-d544-4a317d880e0e@FreeBSD.org> In-Reply-To: <CAJm2B-=Sj3D117pHvTHoefVvWJL8nPpG7XecwVNo4npNohLk6A@mail.gmail.com> References: <2efeb912dbbba733826b79513b4f9f22@FreeBSD.org> <27cc744e-acbe-c550-880e-59bf00986842@FreeBSD.org> <c91b88de3c3dd25e4859e9b7e5420f14@FreeBSD.org> <a70da12d-8c33-fa87-56d2-86084aaf2bd4@FreeBSD.org> <CAJm2B-=Sj3D117pHvTHoefVvWJL8nPpG7XecwVNo4npNohLk6A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------8BgEDO0Xs0YSQyQ9x79hkHg6 Content-Type: multipart/mixed; boundary="------------BpDETgjsCkMFMtqPXoI09ihH"; protected-headers="v1" From: Stefan Esser <se@FreeBSD.org> To: Damjan Jovanovic <damjan.jov@gmail.com>, Larry Rosenman <ler@freebsd.org> Cc: Freebsd ports <freebsd-ports@freebsd.org>, Developers <developers@freebsd.org> Message-ID: <4d365115-5996-8668-d544-4a317d880e0e@FreeBSD.org> Subject: Re: sysutils/lsof: help! References: <2efeb912dbbba733826b79513b4f9f22@FreeBSD.org> <27cc744e-acbe-c550-880e-59bf00986842@FreeBSD.org> <c91b88de3c3dd25e4859e9b7e5420f14@FreeBSD.org> <a70da12d-8c33-fa87-56d2-86084aaf2bd4@FreeBSD.org> <CAJm2B-=Sj3D117pHvTHoefVvWJL8nPpG7XecwVNo4npNohLk6A@mail.gmail.com> In-Reply-To: <CAJm2B-=Sj3D117pHvTHoefVvWJL8nPpG7XecwVNo4npNohLk6A@mail.gmail.com> --------------BpDETgjsCkMFMtqPXoI09ihH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 13.06.22 um 03:01 schrieb Damjan Jovanovic: > >> PS: A patch that applies the ZFS fixes to sysutils/lsof can be > >> =C2=A0=C2=A0=C2=A0 fetched from: > >> > >> =C2=A0=C2=A0=C2=A0 https://people.freebsd.org/~se/ports/lsof-por= t-zfs-patch.diff > <https://people.freebsd.org/~se/ports/lsof-port-zfs-patch.diff>; > > > > Thanks, Stefan. > > =C2=A0=C2=A0 What will it take to get those 2 differential review= s in to the system? >=20 > Hi Larry, >=20 > I have marked D34184 and D34323 as accepted, since these patches co= uld > be applied without conflicts (except for the version updates in par= am.h). >=20 >=20 >=20 > No no no! >=20 > DO NOT accept D34323, lsof should be patched to use the superior implem= entation > in D34756. I was adding a comment that you may want to close the abandoned revision,= but was surprised to notice that I could close it as well, and have done that to avoid future confusion ... I had looked at D34756, but had only seen the patch to update the nfs4 AC= L access functions in sys/ufs/ufs/acl.h. Looking again I see that there are a lot of other patches in the history = of that review. Is there an easy way to fetch them all in one go, or do they have to be individually fetched and applied? > Sorry I've been busy, I'll try update https://github.com/lsof-org/lsof/= pull/184 > <https://github.com/lsof-org/lsof/pull/184>; to use it soon. OK, as reported the patches work after resolving the conflicts and with D34323 applied to the kernel sources. I think that the fork in https://github.com/stesser/lsof/ could be a base= for your update of the pull request for D34576, since it at least resolve= s the issues the pull request had. Best regards, STefan --------------BpDETgjsCkMFMtqPXoI09ihH-- --------------8BgEDO0Xs0YSQyQ9x79hkHg6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmKm5fEFAwAAAAAACgkQR+u171r99UT1 /AgAuICRYdXSR4IsxqqF1c4pWf9IZ7e3cSm/bCo1KW7ES2DxtIfKqO0u4gn0hBeofjkjpQ9o/7uI ePBngYlS/FrFq8cWbZEPmz+DWsGcPztySxSJ2ODcFMZzMuxsuCbYT9w78RThk6e1Tou0NmkERB8Y KEAl3BJXPhjRuQPb78QMydFgEx47OW3dE72vkFvknY0wiYVzuWXlfzHd0Rr9jv8zEMaMHM1pPpQ0 sYHzthz2Y7EdTDhE2HVClqdFn5RFUJV92AFPXuNT7qWKkyjhiSUxxY2iEXNoUWF2MBOf56JgoN7U 03Oaey4X8wQTQVXm4jdSUQP9S3/LHWq6CQ7s+Tyr/Q== =xgHU -----END PGP SIGNATURE----- --------------8BgEDO0Xs0YSQyQ9x79hkHg6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4d365115-5996-8668-d544-4a317d880e0e>