From owner-freebsd-hackers@FreeBSD.ORG  Sun Jun 15 02:14:42 2014
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 025C456B
 for <freebsd-hackers@freebsd.org>; Sun, 15 Jun 2014 02:14:42 +0000 (UTC)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C677823CC
 for <freebsd-hackers@freebsd.org>; Sun, 15 Jun 2014 02:14:41 +0000 (UTC)
Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46])
 by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id B956B20A70
 for <freebsd-hackers@freebsd.org>; Sat, 14 Jun 2014 22:14:38 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute6.internal (MEProxy); Sat, 14 Jun 2014 22:14:38 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=
 messagingengine.com; h=message-id:date:from:reply-to
 :mime-version:to:cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding; s=smtpout; bh=C4x502KwaQXXUnrUMAH64a
 u40pI=; b=Ie0NEwjQE3n5GAInCADiAWYvPN1GUbiZOtTgGyWFKutWqwNt7MS/b8
 8mURopGcbCIm2SGUwpXNX+5T/k6FofEHqNDaYfabEfHanD2winiU8BsvAXOpAuJq
 uiFSRaaLa0Kvfv71o4964n4q0i7LzQAiBOTCqmIuHW3dzzEzL3lPs=
X-Sasl-enc: pI9WJ3ougalTN0G5QUavao/3a6LroE3rCiQeZPyCs4lJ 1402798478
Received: from [192.168.1.35] (unknown [203.206.138.26])
 by mail.messagingengine.com (Postfix) with ESMTPA id C043BC00005;
 Sat, 14 Jun 2014 22:14:36 -0400 (EDT)
Message-ID: <539D01A0.50506@freebsd.org>
Date: Sun, 15 Jun 2014 12:14:56 +1000
From: Darren Reed <darrenr@freebsd.org>
Reply-To: darrenr@freebsd.org
Organization: FreeBSD
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Chris Torek <torek@torek.net>
Subject: Re: FreeBSD 10.0 adaptive mutex with strange mtx_lock value = panic
References: <201406141010.s5EAAtS0087393@elf.torek.net>
In-Reply-To: <201406141010.s5EAAtS0087393@elf.torek.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@freebsd.org, Mateusz Guzik <mjguzik@gmail.com>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jun 2014 02:14:42 -0000

On 14/06/2014 8:10 PM, Chris Torek wrote:
>> I added "options INVARIANTS" to a kernel and recompiled..
>>
>> Well, I tried to recompile - compiling ends like this:
>>
>> cam_periph.o: In function `cam_periph_find':
>> /usr/src/sys/amd64/compile/DEBUG/../../../cam/cam_periph.c:301:
>> undefined reference to `__mtx_assert'
> [etc]
> 
> The INVARIANTS option requires the INVARIANT_SUPPORT option.
> 
> I believe INVARIANTS ought to just automatically turn on
> INVARIANT_SUPPORT, really.  But it's pretty minor, once you
> know.

Thanks and yes, I think you're right.

Too bad we can't build that logic into the conf files.

Darren