From owner-freebsd-multimedia@freebsd.org Wed Sep 21 12:09:22 2016 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD7AFBE3947 for ; Wed, 21 Sep 2016 12:09:22 +0000 (UTC) (envelope-from herbert@mailbox.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A29C6CA4 for ; Wed, 21 Sep 2016 12:09:22 +0000 (UTC) (envelope-from herbert@mailbox.org) Received: by mailman.ysv.freebsd.org (Postfix) id A1F43BE3946; Wed, 21 Sep 2016 12:09:22 +0000 (UTC) Delivered-To: multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A19E5BE3945 for ; Wed, 21 Sep 2016 12:09:22 +0000 (UTC) (envelope-from herbert@mailbox.org) Received: from mx2.mailbox.org (mx2.mailbox.org [80.241.60.215]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.mailbox.org", Issuer "SwissSign Server Silver CA 2014 - G22" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 654A8CA3 for ; Wed, 21 Sep 2016 12:09:21 +0000 (UTC) (envelope-from herbert@mailbox.org) Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 8F258437A3; Wed, 21 Sep 2016 14:03:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= content-type:content-type:mime-version:references:in-reply-to :subject:subject:from:from:message-id:date:date:received; s= mail20150812; t=1474459391; bh=lSoYfBHwp5od4S666BtxTjGU3x149lWaV /zGHGJKNZ4=; b=ssZxdbfOl6CBptsUVlBD1lIBuq+Gh5ViHy+3jRmKqHhMaYJvO HogX1k/jBJvsiNvuOItP/8fKhVFvZ9i0CDnr5gRKMZQUm4VhylitrRM8Bn/NIkyE AzqvwumiK2W3R0NVvJaV3xkvEvuDV5w72XBUNs4ViwpTWZMmSn2K9UZiu3KfQ2Na w/NC8O7xfoLL9kn2XibK5NKS02Q4ibp5BkNAyY/QhgTTsJ29M3Jrsrg+GNbEwUSC MNbnuZN3ZsFWIsRGDe0hNpvuUCC91Klhuc2FtqPZfTQrYoDVeWZVjWGsGDmj+Ely C0+QduF7mM7J3kKfSCQmUqjTFJENJyDzDOz9w== X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id GYCLZh8OFjxe; Wed, 21 Sep 2016 14:03:11 +0200 (CEST) Date: Wed, 21 Sep 2016 14:03:10 +0200 Message-ID: <867fa5wjcx.wl-herbert@mailbox.org> From: "Herbert J. Skuhra" To: Kevin Oberman Cc: multimedia@freebsd.org Subject: Re: Update mp4v2 to version 3.0.1.1 In-Reply-To: References: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 12:09:22 -0000 Kevin Oberman skrev: > > I am just submitted a PR, > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212785 to update mp4v2 to > 3.0.1.1 and change the source to github. > > First port I've submitted in about a decade, so the submission format may > not be right. Please point out everything I did wrong. I've downloaded the patch and applied it with 'svnlite patch'. Now 'make patch' fails because patch-GNUmakefile.in does not apply cleanly. If I remove the patch or apply it manually 'make check-plist' fails: ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: lib/libmp4v2.so.1 Error: Orphaned: lib/libmp4v2.so.1.9.1 ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: lib/libmp4v2.so.3 Error: Missing: lib/libmp4v2.so.3.0.1 ===> Error: Plist issues found. > In the comments I included a list of ports needing a PORT_REVISION bump. Are you sure that this is sufficient? Do these ports still build afterwards? I guess not. e.g. faac requires a patch to build against mp4v2 2.0.0: And why do you choose version 3.0.0.1 and not 2.0.0? Version 3.x is obviously not official yet: The configure script reports: configure: --> --> Configuring MP4v2 2.0.0 --> I've checked some Linux Distributions (Debian, Arch, Gentoo, etc.) and they all ship 2.0.0. PBKAC or have you submitted the wrong/an untested patch? -- Herbert