From owner-cvs-all@FreeBSD.ORG Tue Apr 10 20:38:43 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6D1031065675; Tue, 10 Apr 2012 20:38:43 +0000 (UTC) (envelope-from ohauer@FreeBSD.org) Received: from p578be941.dip0.t-ipconnect.de (p578be941.dip0.t-ipconnect.de [87.139.233.65]) by mx1.freebsd.org (Postfix) with ESMTP id 206278FC12; Tue, 10 Apr 2012 20:38:43 +0000 (UTC) Received: from [192.168.0.100] (cde1100.uni.vrs [192.168.0.100]) (Authenticated sender: ohauer) by p578be941.dip0.t-ipconnect.de (Postfix) with ESMTPSA id B3EF120869; Tue, 10 Apr 2012 22:38:40 +0200 (CEST) Message-ID: <4F849A4F.6030206@FreeBSD.org> Date: Tue, 10 Apr 2012 22:38:39 +0200 From: Olli Hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jason Helfman References: <201204092207.q39M7Qdp013689@repoman.freebsd.org> <20120410194839.GB83964@dormouse.experts-exchange.com> In-Reply-To: <20120410194839.GB83964@dormouse.experts-exchange.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Olli Hauer , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/rancid Makefile distinfo pkg-plist ports/net-mgmt/rancid/files patch-bin-rancid.in patch-bin__control_rancid.in patch-etc::Makefile.am patch-etc::Makefile.in patch-etc__Makefile.am patch-etc__Makefile.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: ohauer@FreeBSD.org List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2012 20:38:43 -0000 On 2012-04-10 21:48, Jason Helfman wrote: > On Mon, Apr 09, 2012 at 10:07:26PM +0000, Olli Hauer thus spake: >> ohauer 2012-04-09 22:07:26 UTC >> >> FreeBSD ports repository >> >> Modified files: >> net-mgmt/rancid Makefile distinfo pkg-plist >> Added files: >> net-mgmt/rancid/files patch-bin__control_rancid.in >> patch-etc__Makefile.am >> patch-etc__Makefile.in >> Removed files: >> net-mgmt/rancid/files patch-bin-rancid.in >> patch-etc::Makefile.am >> patch-etc::Makefile.in >> Log: >> - update to version 2.3.8 >> [...] > Can you please look at this pr, as I took it for a rancid update. > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166585 > > This port doesn't consider package installation users and clobbers existing > configurations. > > Per the Handbook: > If there is a very good reason not to install a working configuration file > by default, leave the @exec line out of pkg-plist and add a message pointing > out that the user must copy and edit the file before the software will work. > > Regarding the handbook entry, I don't know if this is the case for this > software, but I put the pr into feedback so I could engage the maintainer > regarding this, but have not heard anything. > Hi Jason, I can mybe agree on the first patch but the second seems problematic and should be optional http://www.shrubbery.net/pipermail/rancid-discuss/2012-February/006235.html The provided sample configuration will definitive not work. It is only a template since you have to customize it for your environ and create additional config files in the ~rancid home directory + mail/aliases entries +tacacs / radius accounts (or what ever you use for tools for authentication/authorisation in your network) ... Given for this port I find it more handy to have a the folder etc/rancid with a template the an empty folder with a .keepme file and a message from where I can copy the template.