From owner-cvs-all Wed May 31 11: 0:27 2000 Delivered-To: cvs-all@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id C186137BDEA for ; Wed, 31 May 2000 11:00:16 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: (qmail 6896 invoked from network); 31 May 2000 18:00:13 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 31 May 2000 18:00:13 -0000 Date: Thu, 1 Jun 2000 04:00:09 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Peter Wemm Cc: Mike Smith , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/quot quot.c In-Reply-To: <20000531172817.2AFFC1CE1@overcee.netplex.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 31 May 2000, Peter Wemm wrote: > Bruce Evans wrote: > > > open(PATH_DEV "rmt0", ... > > > > This would break K&R support :-), and wouldn't work in most contexts > > (the basename is normally from argv[]; for dump(8) it may be from the > > environment). > > How did I just *know* you were going to say that. You should have said > "break K&R support even more" - it's already pretty badly broken. Troll food :-). It's only slightly broken in sources that once supported K&R. E.g., in the part of dump(8) that handles _PATH_DEV: Script started on Thu Jun 1 03:50:14 2000 ttyv2:bde@besplex:/usr/src/sbin/dump> make -k CC='bcc -G -Dconst=' dumprmt.o bcc -G -Dconst= -O -pipe -DRDUMP -I/usr/src/sbin/dump/../../libexec/rlogind -c /usr/src/sbin/dump/dumprmt.c /usr/src/sbin/dump/dumprmt.c:366.9: error: errno undeclared *** Error code 1 (continuing) ttyv2:bde@besplex:/usr/src/sbin/dump> exit Script done on Thu Jun 1 03:50:30 2000 Here the breakage is just a bug (someone fixed `extern int errno' by including , but included it in the wrong place). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message