From owner-dev-commits-src-all@freebsd.org Wed Jun 23 17:47:16 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 156B0654DA7; Wed, 23 Jun 2021 17:47:16 +0000 (UTC) (envelope-from lutz@iks-jena.de) Received: from annwfn.iks-jena.de (annwfn.iks-jena.de [IPv6:2001:4bd8::19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4G99h36Rg5z3NTD; Wed, 23 Jun 2021 17:47:15 +0000 (UTC) (envelope-from lutz@iks-jena.de) X-SMTP-Sender: IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f Received: from belenus.iks-jena.de (belenus.iks-jena.de [IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f]) by annwfn.iks-jena.de (8.15.2/8.15.2) with ESMTPS id 15NHl4la029127 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 23 Jun 2021 19:47:04 +0200 X-MSA-Host: belenus.iks-jena.de Received: (from lutz@localhost) by belenus.iks-jena.de (8.14.3/8.14.1/Submit) id 15NHl4BK021455; Wed, 23 Jun 2021 19:47:04 +0200 Date: Wed, 23 Jun 2021 19:47:04 +0200 From: Lutz Donnerhacke To: Alexander Richardson Cc: Lutz Donnerhacke , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: 935fc93af157 - main - libalias: Switch to efficient data structure for outgoing traffic Message-ID: <20210623174704.GB21369@belenus.iks-jena.de> References: <202106192010.15JKAbQ8061792@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-message-flag: Please send plain text messages only. Thank you. User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 4G99h36Rg5z3NTD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 17:47:16 -0000 On Wed, Jun 23, 2021 at 11:08:13AM +0100, Alexander Richardson wrote: > On Sat, 19 Jun 2021 at 21:10, Lutz Donnerhacke wrote: > > commit 935fc93af157dee352eb4b6c83f8a2a9e7fd9a4e > > Author: Lutz Donnerhacke > > AuthorDate: 2021-05-27 21:42:54 +0000 > > Commit: Lutz Donnerhacke > > CommitDate: 2021-06-19 20:09:44 +0000 > > > > libalias: Switch to efficient data structure for outgoing traffic [shorten the output to make the messages readable] > This commit appears to have introduced a SIGBUS when running some of the tests: > > Program terminated with signal SIGBUS, Bus error. > #0 cmp_out (a=0x80180e080, b=0x5a5a5a5a5a5a5a5a) at > /usr/src/sys/netinet/libalias/alias_db.c:413 > 413 /usr/src/sys/netinet/libalias/alias_db.c: No such file or directory. > #0 cmp_out (a=0x80180e080, b=0x5a5a5a5a5a5a5a5a) at > /usr/src/sys/netinet/libalias/alias_db.c:413 > #1 splay_out_SPLAY (head=head@entry=0x8018100e0, > elm=elm@entry=0x80180e080) at > /usr/src/sys/netinet/libalias/alias_db.c:425 > #2 0x00000008010908d9 in splay_out_SPLAY_REMOVE (head=0x8018100e0, > elm=0x80180e080) at /usr/src/sys/netinet/libalias/alias_db.c:425 > #3 DeleteLink (plnk=plnk@entry=0x7fffffffd530, > deletePermanent=, deletePermanent@entry=1) at > /usr/src/sys/netinet/libalias/alias_db.c:883 > #4 0x0000000801091251 in CleanupAliasData (la=0x8018100c0, > deletePermanent=1) at /usr/src/sys/netinet/libalias/alias_db.c:819 > #5 LibAliasUninit (la=0x8018100c0) at > /usr/src/sys/netinet/libalias/alias_db.c:2542 [...] A use after free in the final cleanup. Thank you for catching this. It will delay the MFC until this issue is solved. > Source: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/18438/testReport/junit/sys.netinet.libalias/3_natin/1_portforward/ > See https://ci.freebsd.org/job/FreeBSD-main-amd64-test/18438/#showFailuresLink > Could you have a look? Yep, try to reproduce.