From owner-freebsd-stable@FreeBSD.ORG  Sat Jun 22 13:56:28 2013
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id AD42F875
 for <freebsd-stable@freebsd.org>; Sat, 22 Jun 2013 13:56:28 +0000 (UTC)
 (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 6F46F1ECC
 for <freebsd-stable@freebsd.org>; Sat, 22 Jun 2013 13:56:28 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7::751d:fc62:4355:d021] (unknown
 [IPv6:2001:7b8:3a7:0:751d:fc62:4355:d021])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id BD55E5C43;
 Sat, 22 Jun 2013 15:56:20 +0200 (CEST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: sshd didn't run after upgrade to FreeBSD 8.4
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <CA+7WWSevOGE5dQ4Ld_mBf_Dp7-f3+9AMz7uRihzeqM2rsZsGVA@mail.gmail.com>
Date: Sat, 22 Jun 2013 15:56:18 +0200
Content-Transfer-Encoding: 7bit
Message-Id: <60F7DD16-087B-4BE1-B4B0-D37B7B62813B@FreeBSD.org>
References: <51C22E11.3020008@quip.cz>
 <CA+7WWScSS16URJNQ3h1WjoXaBhG_gBn=ERb_SiCc4y+DhBeuKA@mail.gmail.com>
 <51C23ED9.7070107@quip.cz>
 <CA+7WWSfwXOh_g1hi-5C=hG8NRepNC1NzZjqscQdtqB=fGN2dWg@mail.gmail.com>
 <FB3070EFDC484C75AB519EA00A237D3E@multiplay.co.uk>
 <CA+7WWSebzFA2heKMAptnFdXYehyAhpNFki7XATzypTreArrc=A@mail.gmail.com>
 <51C2499B.2060209@quip.cz>
 <CA+7WWSevOGE5dQ4Ld_mBf_Dp7-f3+9AMz7uRihzeqM2rsZsGVA@mail.gmail.com>
To: Kimmo Paasiala <kpaasial@gmail.com>
X-Mailer: Apple Mail (2.1508)
Cc: Steven Hartland <killing@multiplay.co.uk>,
 freebsd-stable Stable <freebsd-stable@freebsd.org>,
 Miroslav Lachman <000.fbsd@quip.cz>
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Jun 2013 13:56:28 -0000

On Jun 20, 2013, at 02:24, Kimmo Paasiala <kpaasial@gmail.com> wrote:
...
> Ok, this is crazy. If you put one space after the VersionAddendum
> keyword you get exactly what you want, an empty VersionAddendum
> string. If there's no space but a newline right after the
> VersionAddendum keyword, sshd(8) complains about the line and refuses
> to start. So this is ok (without the single quotes, they are just to
> show the endings of the lines):
> 
> 'VersionAddendum '
> 
> But this is not:
> 
> 'VersionAddendum'
> 
> What are the OpenSSH devs thinking?


I assume they did not take this scenario into account at all.  The
VersionAddendum setting had been a custom FreeBSD addition for some
time, and was not available at all in upstream OpenSSH.  When upstream
decided to add it, they did not specifically care about backwards
compatibility with (until that time) non-standard configuration files...

-Dimitry