From owner-cvs-all Tue Aug 14 11: 6:58 2001 Delivered-To: cvs-all@freebsd.org Received: from pcnet1.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by hub.freebsd.org (Postfix) with ESMTP id B287D37B408; Tue, 14 Aug 2001 11:06:50 -0700 (PDT) (envelope-from eischen@vigrid.com) Received: (from eischen@localhost) by pcnet1.pcnet.com (8.8.7/PCNet) id OAA09011; Tue, 14 Aug 2001 14:06:06 -0400 (EDT) Date: Tue, 14 Aug 2001 14:06:05 -0400 (EDT) From: Daniel Eischen To: John Baldwin Cc: "Daniel M. Eischen" , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Peter Wemm Subject: Re: cvs commit: src/include stdio.h src/lib/libc Makefilesrc/lib In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 14 Aug 2001, John Baldwin wrote: > On 14-Aug-01 Daniel M. Eischen wrote: > > Peter Wemm wrote: > >> > >> peter 2001/08/13 14:48:44 PDT > >> > >> Modified files: > >> include stdio.h > >> lib/libc Makefile > >> lib/libc/stdio findfp.c > >> Log: > >> Rip out the old __stdin/out/err stuff. It was completely 100% useless. :-( > >> It was foiled because of dynamic copy relocations that caused compile-time > >> space to be reserved in .bss and at run time a blob of data was copied to > >> that space and everything used the .bss version.. The problem is that > >> the space is reserved at compile time, not runtime... So we *still* could > >> not change the size of FILE. Sigh. :-( > >> > >> Replace it with something that does actually work and really does let us > >> make 'FILE' extendable. It also happens to be the same as Linux does in > >> glibc, but has the slight cost of a pointer. Note that this is the > >> same cost that 'fp = fopen(), fprintf(fp, ...); fclose(fp);' has. > >> Fortunately, actual references to stdin/out/err are not all that common > >> since we have implicit stdin/out/err-using versions of functions > >> (printf() vs. fprintf()). > > > > Yes! > > > > So do we allow FILE to be extended only after bumping the library > > version once (after 5.0-release)? And thereafter all extensions to > > FILE do not need a version bump? > > We've already bumped libc for 5.x. Assuming this works ok, we shouldn't need > any further bumps for extending FILE. True. I guess the real problem is the other libraries that reference stdin, stdout, stderr. These need to be rebuilt with the new stdio.h and libc in order to avoid any impact from future FILE changes. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message