From nobody Mon Oct 6 16:43:32 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cgQ7m3vtRz69fJP for ; Mon, 06 Oct 2025 16:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cgQ7m3JrDz3qLc for ; Mon, 06 Oct 2025 16:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759769012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=klg1RUqfAeDYfLMLUto34LmnvTGYfpMavRDAvqNjxug=; b=qagEClmvLtAJCLaZ6MLKqjbI4i6pM+sXa53gOGpzzY2Cp8mk/zf3ctLObHPDbVRxqmMgQ8 8xRZgk50V5WEm3yPUmic02v6xlMPe51fFEEudKLypYwTM0U/CaTnhiI4zSdofNsdXESIZ/ Uy+0A4+ruV33Odi0q6rEyc6uwxABXgmQ/VN4Tr67QbMfpVeEs2oVyMWxSEjiE12AFv7VTi TXiqGTBV3vYnkRydFr6pA5jwTSdpdnIZ9xTUSQTbhUIK3ekux+OL7b1dIQt875ZD+U0dBR OEGwAhLOJ/na+sbYPnkeY3AuBtK7SXl6+rp3exZoD/sSegXRo2l43QG4QrBrpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759769012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=klg1RUqfAeDYfLMLUto34LmnvTGYfpMavRDAvqNjxug=; b=vtCU1qWBn3F/Qm8E3TLCa8/dxvs8iTcGi3mHLPWudw3HlblH2GURX7qFI5Nk7S6pbxfE/4 gkc39XOfFCmLbc+Z6QbYX2fQi/uKe4k+qYr154STxD3ZA6pGXC7ohaI8UY+FenboGJMpzi Z5rJImz0kPFrd+UX846TNBYlsnlI5AdnXHUrfP3PAjEbkobKq/dKizp0MzQ8YzWpo0HP2R tMcc8EcRqsdsNGX3ls1/FqiH8GL8EtYzVPXS7movTTwlTORJEdcxMsLFtf88lHJZn2n1R3 PiH20DqY3DL/3HSsOInOyVisJUtL4rxFYIofFI+ZoERELpIAvsQ+bKGnq+UZ2w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759769012; a=rsa-sha256; cv=none; b=cXWYTRR8l956M8YecPwk7smYs4EJQ16JwfqvmxQGUiEo94yZVccKzAMmSbtH5fj8f2A8EB Lgyxau1fwCQNsWsSTxx6THq+kCadMH9XQURJbw38n9VNWfcFNMNY+krPNcFZxZjL5o1ADa QL4mHd7tuXgfGHAR3uDxC8Tos67OAq8hp7rDfyF8N6Qh7BNw9NYdsEzYfCj4fy8lEsOzxQ pIUqMnT1GOtg8fZynJ8rSmAqbi267VyzWqxJr+sEQ6eGYH0va/VcDF0bE5t6ih6hXVC09E LBzwTzzgEfqgvDO5GY0r2PXJ/KPWJlgSM3T9LAiLyzpRt9BHmS67YpnOxx25FQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cgQ7m2k28z16Yc for ; Mon, 06 Oct 2025 16:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 596GhWSt076225 for ; Mon, 6 Oct 2025 16:43:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 596GhWC0076224 for bugs@FreeBSD.org; Mon, 6 Oct 2025 16:43:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 290050] netlink: snl_init_writer() does not report the error flag appropriately Date: Mon, 06 Oct 2025 16:43:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bruno.silvestre@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D290050 Bug ID: 290050 Summary: netlink: snl_init_writer() does not report the error flag appropriately Product: Base System Version: 14.3-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: bruno.silvestre@gmail.com snl_init_writer() always set the error flag as 'false'. Here is a fix suggestion: --- netlink_snl_old.h 2025-10-02 14:17:36.369302000 -0300 +++ netlink_snl.h 2025-10-02 14:17:56.411429000 -0300 @@ -1021,20 +1021,20 @@ }; static inline void snl_init_writer(struct snl_state *ss, struct snl_writer *nw) { + nw->error =3D false; nw->size =3D SNL_WRITER_BUFFER_SIZE; nw->base =3D (char *)snl_allocz(ss, nw->size); if (nw->base =3D=3D NULL) { nw->error =3D true; nw->size =3D 0; } nw->offset =3D 0; nw->hdr =3D NULL; - nw->error =3D false; nw->ss =3D ss; } static inline bool snl_realloc_msg_buffer(struct snl_writer *nw, size_t sz) --=20 You are receiving this mail because: You are the assignee for the bug.=