From owner-freebsd-ports  Thu Aug 20 19:08:27 1998
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id TAA12686
          for freebsd-ports-outgoing; Thu, 20 Aug 1998 19:08:27 -0700 (PDT)
          (envelope-from owner-freebsd-ports@FreeBSD.ORG)
Received: from vader.cs.berkeley.edu (vader.CS.Berkeley.EDU [128.32.38.234])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA12667;
          Thu, 20 Aug 1998 19:08:25 -0700 (PDT)
          (envelope-from asami@vader.cs.berkeley.edu)
Received: from silvia.hip.berkeley.edu (sji-ca10-63.ix.netcom.com [205.186.214.63]) by vader.cs.berkeley.edu (8.8.7/8.7.3) with ESMTP id TAA12674; Thu, 20 Aug 1998 19:07:43 -0700 (PDT)
Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.8.8/8.6.9) id TAA10850; Thu, 20 Aug 1998 19:07:40 -0700 (PDT)
Date: Thu, 20 Aug 1998 19:07:40 -0700 (PDT)
Message-Id: <199808210207.TAA10850@silvia.hip.berkeley.edu>
To: hoek@hwcn.org
CC: obrien@NUXI.com, ports@FreeBSD.ORG, hoek@FreeBSD.ORG
In-reply-to: <Pine.GSO.3.96.980820183017.14347B-100000@james.hwcn.org> (message from Tim Vanderhoek on Thu, 20 Aug 1998 19:10:56 -0400 (EDT))
Subject: Re: cvs commit: ports/lang/glibstdc++28 Makefile
From: asami@FreeBSD.ORG (Satoshi Asami)
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

 * > +.if !target(generate-plist)
 * > +generate-plist:
 * > +	@if [ ! -f ${PLIST} -o ! -f ${COMMENT} -o ! -f ${DESCR} ]; then ${ECHO} "** Missing package files for ${PKGNAME}."; exit 1; fi
 * 
 * I'm not sure this is quite right.  For example, the ilu port
 * creates its whole PLIST in the post-install target.  To make the
 * port work with the current bsd.port.mk, I added
 * 
 * TMPPLIST=	${PLIST}
 * 
 * Which won't work with the new change.

That's not right.  The PLIST should just be generated before
generate-plist is run.

We decided to stick it in post-install to give people chances to
change with the generated file (${TMPPLIST}).  Maybe we can move it
back to after post-install and add a new target ("post-generate-plist"?)
for fiddling with it.  Eek.

Personally I think it can just be solved by having ilu generate PLIST
in do-install.  All you need to do is to change "post-install:" to
"do-install:" and add a "cd ${WRKSRC}; ${MAKE} install" in front of
that target, right?

 * I think just keeping the test in fake-pkg: is enough, although I
 * do have patches that change "generate-plist:" to "${TMPPLIST}:" 
 * and make fake-pkg depend on "${TMPPLIST}".  This is kinda cool
 * and also should solve the problem (although writing
 * generate-plist target that forces plist generation iff TMPPLIST
 * and PLIST refer to different files was tricky).

Patch patch! :)

 * I'm not sure this is a good idea...

Yeah, I'm not so sure either.  Never mind.

Satoshi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message