From owner-cvs-src@FreeBSD.ORG Thu May 6 22:23:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 010BF16A4CE; Thu, 6 May 2004 22:23:59 -0700 (PDT) Received: from alcanet.com.au (mail2.alcanet.com.au [203.62.196.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2052043D1F; Thu, 6 May 2004 22:23:55 -0700 (PDT) (envelope-from peter.jeremy@alcatel.com.au) Received: from sydsmtp02.alcatel.com.au (IDENT:root@localhost.localdomain [127.0.0.1])i475NoiL007202; Fri, 7 May 2004 15:23:50 +1000 Received: from gsmx07.alcatel.com.au ([139.188.20.247]) by sydsmtp02.alcatel.com.au (Lotus Domino Release 5.0.12) with ESMTP id 2004050715234981:845 ; Fri, 7 May 2004 15:23:49 +1000 Received: from gsmx07.alcatel.com.au (localhost [127.0.0.1]) i475NnHQ080875; Fri, 7 May 2004 15:23:49 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Received: (from jeremyp@localhost) by gsmx07.alcatel.com.au (8.12.9p2/8.12.9/Submit) id i475Nll5080874; Fri, 7 May 2004 15:23:47 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Date: Fri, 7 May 2004 15:23:46 +1000 From: Peter Jeremy To: Tim Kientzle Message-ID: <20040507052346.GA80829@gsmx07.alcatel.com.au> Mail-Followup-To: Tim Kientzle , cvs-src@freebsd.org, Tim Kientzle , src-committers@freebsd.org, cvs-all@freebsd.org, Andrew.Li@alcatel.com.au References: <200405041721.i44HL22l029797@repoman.freebsd.org> <20040504232632.GA69416@gsmx07.alcatel.com.au> <40986014.4010507@kientzle.com> Mime-Version: 1.0 In-Reply-To: <40986014.4010507@kientzle.com> User-Agent: Mutt/1.4.2i X-MIMETrack: Itemize by SMTP Server on SYDSMTP02/AlcatelAustralia(Release 5.0.12 |February 13, 2003) at 07/05/2004 03:23:49 PM,|February 13, 2003) at 07/05/2004 03:23:50 PM, Serialize complete at 07/05/2004 03:23:50 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline cc: cvs-src@freebsd.org cc: Tim Kientzle cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Andrew.Li@alcatel.com.au Subject: Re: cvs commit: src/usr.bin/tar fts.c fts.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2004 05:23:59 -0000 On 2004-May-04 20:31:32 -0700, Tim Kientzle wrote: >Peter Jeremy wrote: >>Since a colleague of mine has just finished porting fts(3) to Tru64, > >Patches? ... >So far, I've heard reports from people using bsdtar/libarchive on >FreeBSD 5, FreeBSD 4, and Linux. If someone sends me patches for >another system, I'm happy to integrate them. ;-) Actually, we were porting du(1) rather than bsdtar/libarchive. The du built into Tru64 is seriously broken[1] and the FreeBSD one seemed an easy solution. The fts(3) changes are functionally equivalent to yours but implemented without the #ifdef's so the code is not portable. [1] If the content of a directory changes whilst it is processing the directory, it will give nonsense results - similar to: $ du -sk . du: File not found ./foo 0 ./foo $ >>Also, why wasn't this done as a repocopy? This would have made it far >>easier to see the changes. > >Duh! My inexperienced commiter-ness is showing through again, >isn't it? Raise the issue with cvs@, it might still be possible (it would mean that two different v1.1's would have existed, but the dates are sufficiently separated that it may be allowed). -- Peter Jeremy