From owner-cvs-all@FreeBSD.ORG Mon Jul 12 14:00:11 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A628B16A4CF; Mon, 12 Jul 2004 14:00:11 +0000 (GMT) Received: from mailout11.sul.t-online.com (mailout11.sul.t-online.com [194.25.134.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 10DBD43D46; Mon, 12 Jul 2004 14:00:11 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from fwd07.aul.t-online.de by mailout11.sul.t-online.com with smtp id 1Bk1Ll-0005s5-06; Mon, 12 Jul 2004 16:00:09 +0200 Received: from Andro-Beta.Leidinger.net (VTx--0Z-wevPUmZvyRTyoeFPE17NGemw+L+3rjzCqG7WM5fbGd+Lwv@[217.83.30.91]) by fmrl07.sul.t-online.com with esmtp id 1Bk1LZ-07suxM0; Mon, 12 Jul 2004 15:59:57 +0200 Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) i6CDxvNj010870; Mon, 12 Jul 2004 15:59:57 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Date: Mon, 12 Jul 2004 16:00:09 +0200 From: Alexander Leidinger To: David Schultz Message-Id: <20040712160009.16ebe0c1@Magellan.Leidinger.net> In-Reply-To: <20040709033327.GA14984@VARK.homeunix.com> References: <200407090331.i693VAIL038494@repoman.freebsd.org> <20040709033327.GA14984@VARK.homeunix.com> X-Mailer: Sylpheed-Claws 0.9.12 (GTK+ 1.2.10; i386-portbld-freebsd5.2) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Mon__12_Jul_2004_16_00_09_+0200_QYg96VZ4z5Qpyrj6" X-Seen: false X-ID: VTx--0Z-wevPUmZvyRTyoeFPE17NGemw+L+3rjzCqG7WM5fbGd+Lwv@t-dialin.net cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/msun/src math.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2004 14:00:11 -0000 This is a multi-part message in MIME format. --Multipart=_Mon__12_Jul_2004_16_00_09_+0200_QYg96VZ4z5Qpyrj6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 8 Jul 2004 20:33:27 -0700 David Schultz wrote: > The Intel compiler is too smart for its own good sometimes. > I kept wondering why, despite icc's lack of a __builtin_isgreater(), > it seemed to be using one anyway. It turns out that it had done > some constant propagation and determined the value of my call to the > libm routine __fpclassifyd() statically. Pretty spiffy. In this case the attached patch may be more accurate. Background: The FreeBSD port of icc v8 doesn't define __GNUC__ by default, but icc v8 on linux does it. It gets explicitly disabled in the FreeBSD port. To be on the safe side one should test for !defined(icc) if the code shouldn't be used in the icc case. Bye, Alexander. -- I'm available to get hired (preferred in .lu). http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 --Multipart=_Mon__12_Jul_2004_16_00_09_+0200_QYg96VZ4z5Qpyrj6 Content-Type: text/plain; name="math.h.diff" Content-Disposition: attachment; filename="math.h.diff" Content-Transfer-Encoding: 8bit Index: math.h =================================================================== RCS file: /big/FreeBSD-CVS/src/lib/msun/src/math.h,v retrieving revision 1.40 diff -u -u -r1.40 math.h --- math.h 9 Jul 2004 03:32:39 -0000 1.40 +++ math.h 12 Jul 2004 13:56:09 -0000 @@ -38,7 +38,7 @@ #define __MATH_BUILTIN_CONSTANTS #endif -#if (defined(__GNUC__) && __GNUC__ >= 3) +#if (defined(__GNUC__) && __GNUC__ >= 3 && !defined(__INTEL_COMPILER)) #define __MATH_BUILTIN_RELOPS #endif --Multipart=_Mon__12_Jul_2004_16_00_09_+0200_QYg96VZ4z5Qpyrj6--