From nobody Mon Nov 24 04:00:23 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dFBtc0SLnz6Hyls for ; Mon, 24 Nov 2025 04:00:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dFBtb58B6z3YYm for ; Mon, 24 Nov 2025 04:00:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763956823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e+kLXdgcSaYM8xGagmMA7QYsCC1Zb5ean0pSxBCcZK4=; b=f/wcvYl82BnLQ6URvyV+ZLt8P2a69pTjkzN5hC26vNvP7Vyli9PNfQwqVICXmZOxrgx9k4 1JG4llmnLE+3KlgNUhUX4ZTpFFGrdjekXK28u78fbt+cuw0VpB09ldx9qeRfkWsnShqwJ6 GrHAnci05K+jJPVEgZUlnygNQE6Nx91i3ZznHIkjt1xyjACso3y3m5AJoAZyKXoGNfm+so wECI6JD0ui1WC/Q0AOYAqeVXkIrTBNOVbiigYbRC0a4+FDrHVlrq+EzaZWIxRs36DXoNLp M/sbvxMl/bGNKUKcniHE0JaKCp6kDIPVW3AL/XZQ8YMoH0mFlWYcUWcZ0Etefw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763956823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e+kLXdgcSaYM8xGagmMA7QYsCC1Zb5ean0pSxBCcZK4=; b=aVvC+ZN9CRyRmGgDHQQfgW6jJ+eREpiwTOxJD94DDzqTo5D/CRKs1yogv0GzZwvBiz9fHT KHNo5Uq9ENxy4sjSe9y1IzaBlG3w8W+KIqpfBSXgCOYZCB8nJJ4kuRRbaKNfOO0U54ipK9 t58VUlH18+t2vhToNNFToyG7NFdfw9UF1A5ckmomKlcPg7578qUMnJ49EiTxyJHfdDhOAw ACAEmb8pLwPhryzf5Ymbxhs9LpM94F+dopuDH4ZAgoxbThOw41520AuEp/VoYGtkTSo4rY cH1fVAa1PBV9MUKCcijMV1XDhUT9dcNxJW5lCQTBmBiEZ4IKHiZs/QGWiCHcCg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763956823; a=rsa-sha256; cv=none; b=ksSypVRKh3GZVWcz34wsEq1F3mlOUzB5EtETA4ItDzi8bwW9ZVbcx0taoFIaQKpOzmU7+c 1/xYJ7XBxa3i+l5TeWYh/XEMD/dI6qZGjiahOQf9ETzVAHSnp+34Y+uF1UKKscRGhghKqF p/H+nk3MtuwLxy/gBL7o1H2YRkwR8Sf0aVWkLbUocVWQJ2cvvQ63gnfdlY3aefjK32K6GP dsJkNRyuga17kItotK8neKUvnqHOiU9eHpfXQ21aqJbM8g+n7vqDs/P7Te0pYvr0r6Jb0Y sB17fn0AF7KQoZozORWqbeNncEkVH/76mAD5DnX6ErNOFuUgJdN7kFUyLtuzjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dFBtb4b0hzy8y for ; Mon, 24 Nov 2025 04:00:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 338cb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 24 Nov 2025 04:00:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 25587b30c30a - stable/14 - ntpd: Fix segfault when same IP on multiple interfaces List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 25587b30c30afe8219c2cd34d8e3877418a3612e Auto-Submitted: auto-generated Date: Mon, 24 Nov 2025 04:00:23 +0000 Message-Id: <6923d857.338cb.6f1ebea2@gitrepo.freebsd.org> The branch stable/14 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=25587b30c30afe8219c2cd34d8e3877418a3612e commit 25587b30c30afe8219c2cd34d8e3877418a3612e Author: Cy Schubert AuthorDate: 2025-11-21 00:16:04 +0000 Commit: Cy Schubert CommitDate: 2025-11-24 04:00:14 +0000 ntpd: Fix segfault when same IP on multiple interfaces Use the protype socket to obtain the IP address for an error message. Using the resultant socket address, a NULL because create_interface() had failed, results in SIGSEGV. To reproduce this bug, ifconfig bridge100 create ifconfig bridge100 10.10.10.10/24 ifconfig bridge101 create ifconfig bridge101 10.10.10.10/24 ntpd -n PR: 291119 (cherry picked from commit ac1f48b4a7be104d222dea60f1da946fcb345fb1) --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 9c4f6c1553e3..97b85ee83e36 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -1923,7 +1923,7 @@ update_interfaces( msyslog(LOG_ERR, "cannot bind address %s", - stoa(&ep->sin)); + stoa(&ep2->sin)); } free(ep2); }