From owner-svn-src-head@FreeBSD.ORG Tue Jan 6 20:57:01 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB099106566B; Tue, 6 Jan 2009 20:57:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id A8EA48FC1F; Tue, 6 Jan 2009 20:57:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n06KtLlF039586; Tue, 6 Jan 2009 13:55:22 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 06 Jan 2009 13:55:34 -0700 (MST) Message-Id: <20090106.135534.742957024.imp@bsdimp.com> To: christoph.mallon@gmx.de From: "M. Warner Losh" In-Reply-To: <49627592.60208@gmx.de> References: <20090105194210.P45399@maildrop.int.zabbadoz.net> <20090105204356.GA52934@troutmask.apl.washington.edu> <49627592.60208@gmx.de> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, bz@freebsd.org, src-committers@freebsd.org, sgk@troutmask.apl.washington.edu Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2009 20:57:02 -0000 In message: <49627592.60208@gmx.de> Christoph Mallon writes: : Steve Kargl schrieb: : > Stylistic changes (including whitespace changes) are hard on : > the source repository and are to be avoided without good reason. : : Yet another anachronism in style(9). : (Does that sentence even mean what I think it means? Somehow it sounds : like "there is no good reason, but avoid them anyway" instead of "avoid : them if you have no good reason".) It means "Don't make white space changes because you can, make them because you have some other reason for changing the code." If you are just reading something and notice a space out of whack, don't bother. If you are debugging the code, fixing a bug, adding a feature, go ahead and fix that too: but make two commits. Warner