From owner-freebsd-current@FreeBSD.ORG Thu Apr 16 16:15:15 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A655B10656DB for ; Thu, 16 Apr 2009 16:15:15 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 3B62F8FC1E for ; Thu, 16 Apr 2009 16:15:15 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n3GGFEm8009043 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 16 Apr 2009 09:15:14 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <49E75992.7050106@freebsd.org> Date: Thu, 16 Apr 2009 09:15:14 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Maxim Sobolev References: <49E6DB25.2010601@sippysoft.com> <49E6FF8F.4070403@sippysoft.com> In-Reply-To: <49E6FF8F.4070403@sippysoft.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: stable@freebsd.org, "current@freebsd.org" Subject: Re: kernel compile fails without AH_SUPPORT_AR5416 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2009 16:15:16 -0000 Maxim Sobolev wrote: > Dennis Melentyev wrote: >> Could be worth an entry in UPDATING and/or explicitly added to GENERIC. > > My point is that if the option is mandatory for compiling ath(4) > driver, then there is no point in having this option in the first place. There is an entry in UPDATING and it is present in GENERIC (in HEAD, I didn't commit the changes to RELENG_7 so don't know). When the ath hal src code was imported the meaning of the ath_hal device changed because internal configuration done during binary builds was now exposed. Specifically, the need for AH_SUPPORT_5416 to enable support for the extended descriptor format used by the 11n parts. If you read ath_hal(4) this should be clear--if not please help improve the manual page. However, it so happens you can eliminate this option because config will generate a #define you can use instead to identify the configuration of "ath_hal" but this magic is undocumented and I didn't know about it until ru recently told me. I suggested he go ahead and fixup the code to use it but haven't seen anything. I don't have time right now. Sam