From owner-cvs-src-old@FreeBSD.ORG Sat Apr 17 17:02:31 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 660C41065679 for ; Sat, 17 Apr 2010 17:02:31 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 52A9C8FC18 for ; Sat, 17 Apr 2010 17:02:31 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o3HH2VAx059674 for ; Sat, 17 Apr 2010 17:02:31 GMT (envelope-from alc@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o3HH2VCK059673 for cvs-src-old@freebsd.org; Sat, 17 Apr 2010 17:02:31 GMT (envelope-from alc@repoman.freebsd.org) Message-Id: <201004171702.o3HH2VCK059673@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to alc@repoman.freebsd.org using -f From: Alan Cox Date: Sat, 17 Apr 2010 17:02:17 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Apr 2010 17:02:31 -0000 alc 2010-04-17 17:02:17 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c Log: SVN rev 206761 on 2010-04-17 17:02:17Z by alc Setting PG_REFERENCED on the requested page in swap_pager_getpages() is either redundant or harmful, depending on the caller. For example, when called by vm_fault(), it is redundant. However, when called by vm_thread_swapin(), it is harmful. Specifically, if the thread is later swapped out, having PG_REFERENCED set on its stack pages leads the page daemon to reactivate these stack pages and delay their reclamation. Reviewed by: kib MFC after: 3 weeks Revision Changes Path 1.315 +1 -5 src/sys/vm/swap_pager.c