From owner-svn-src-head@FreeBSD.ORG Tue Mar 25 22:32:13 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A6F82F24; Tue, 25 Mar 2014 22:32:13 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 93C30DF8; Tue, 25 Mar 2014 22:32:13 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s2PMWDLT031034; Tue, 25 Mar 2014 22:32:13 GMT (envelope-from imp@svn.freebsd.org) Received: (from imp@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s2PMWDkE031033; Tue, 25 Mar 2014 22:32:13 GMT (envelope-from imp@svn.freebsd.org) Message-Id: <201403252232.s2PMWDkE031033@svn.freebsd.org> From: Warner Losh Date: Tue, 25 Mar 2014 22:32:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r263750 - head/sys/conf X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Mar 2014 22:32:13 -0000 Author: imp Date: Tue Mar 25 22:32:13 2014 New Revision: 263750 URL: http://svnweb.freebsd.org/changeset/base/263750 Log: Add a '*' to the M modifier string so we match any -gdwarf string (even though it works w/o it for some reason, contrary to our reading of make(1)). Also add a comment explaining things a bit better so there's one less mystery that must be answered with svn blame. Submitted by: ian@ Modified: head/sys/conf/kern.mk Modified: head/sys/conf/kern.mk ============================================================================== --- head/sys/conf/kern.mk Tue Mar 25 22:08:31 2014 (r263749) +++ head/sys/conf/kern.mk Tue Mar 25 22:32:13 2014 (r263750) @@ -164,8 +164,10 @@ CFLAGS+= -fstack-protector .endif # -# Add -gdwarf-2 when compiling -g +# Add -gdwarf-2 when compiling -g on clang. The default starting in v3.4 +# is to generate DWARF version 4. However, our tools don't cope well with +# DWARF 4, so force it to genereate DWARF2, which they understand. # -.if ${COMPILER_TYPE} == "clang" && ${CFLAGS:M-g} != "" && ${CFLAGS:M-gdwarf} == "" +.if ${COMPILER_TYPE} == "clang" && ${CFLAGS:M-g} != "" && ${CFLAGS:M-gdwarf*} == "" CFLAGS+= -gdwarf-2 .endif