Date: Mon, 24 Aug 2015 10:48:07 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824084807.GA93486@ivaldir.etoilebsd.net> In-Reply-To: <20150824070915.GA15244@FreeBSD.org> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> <20150824070915.GA15244@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--cWoXeonUoKmBZSoM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Aug 24, 2015 at 07:09:15AM +0000, Alexey Dokuchaev wrote:
> On Sun, Aug 23, 2015 at 11:43:21PM +0100, Mathieu Arnold wrote:
> > +--On 23 ao??t 2015 08:56:58 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
> > wrote:
> > | +# Unfortunately, the code is not GCC 4.2.1 compatible (due to bugs i=
n GCC
> > | +# itself). Try to use system compiler if it is Clang, otherwise fal=
lback
> > | +# to modern GCC (on older versions of FreeBSD).
> > | +.if ${OSVERSION} < 900014
> > | +USE_GCC=3D yes
> >=20
> > OSVERSION < 900014 will always be false. Please, don't add more checks=
on
> > unsupported versions.
>=20
> The fact that 8.X had reached its EOL merely means we cannot promise that
> things won't break. It does not mean we should immediately pull the plug
> and remove two lines from the Makefile, leaving 8.4 users with a broken
> port.
>=20
> It's up to maintainers to decide whether it's worth supporting some old
> FreeBSD version. Keeping around intricate patches and having to rebase
> and test on every update is a nuisance, so those patches probably deserve
> to rest in attic now. Two lines in the Makefile are hardly a burden.
>=20
> I typically would try to support as many FreeBSD versions as long the
> port stays manageable. Often it's not a problem, and is very polite to
> our users that do not want to upgrade for some reason (e.g. me and my
> laptop are happy with stable/8 and see no reason to update, as it will
> likely pessimize work experience without bringing any benefits over 8.4).
>=20
> That said, OSVERSION < 900014 will not always be false. And why do you
> want to be rude to our users and deliberately break things just because
> we no longer promise that they will work?
>=20
Even in that case, this is wrong anyway as you enforce GCC while should sho=
uld
require a modern compiler via compiler.mk.
regards,
Bapt
--cWoXeonUoKmBZSoM
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlXa2kcACgkQ8kTtMUmk6Ew78gCgu2yb0K6Ylw41nLKRkxXB/aUM
C0cAoLkvWWgzAt3fQRIFSAMahhGzXkWM
=0cwj
-----END PGP SIGNATURE-----
--cWoXeonUoKmBZSoM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150824084807.GA93486>