From owner-cvs-src@FreeBSD.ORG Fri May 26 07:18:01 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D246D16AA28; Fri, 26 May 2006 07:18:01 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from pfepa.post.tele.dk (pfepa.post.tele.dk [195.41.46.235]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7222543D48; Fri, 26 May 2006 07:18:01 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (0x50a07cfc.naenxx7.adsl-dhcp.tele.dk [80.160.124.252]) by pfepa.post.tele.dk (Postfix) with ESMTP id 8CE5BFAC02E; Fri, 26 May 2006 09:17:59 +0200 (CEST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.6/8.13.6) with ESMTP id k4Q7Hmqn007546; Fri, 26 May 2006 09:17:49 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Warner Losh From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 25 May 2006 22:06:11 MDT." <20060525.220611.74708877.imp@bsdimp.com> Date: Fri, 26 May 2006 09:17:48 +0200 Message-ID: <7545.1148627868@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: cvs-src@freebsd.org, scottl@samsco.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/syscons/apm apm_saver.c src/sys/i386/bios apm.c apm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 May 2006 07:18:02 -0000 In message <20060525.220611.74708877.imp@bsdimp.com>, Warner Losh writes: >At the very least, we should mandate that timeouts are a non-sleepable >event. Sleeping just doesn't work there. taskqueues, I'm less sure >of, since short sleeps there work, but do degrade performance. I like >this idea. A couple of years back I did a survey of our timeout callbacks because I was worried about this issue in the context of SMPng. The majority are "mostly OK" (there is a lot of memory allocations with M_WAITOK) and a few are just plain wrong. It's certainly a fixable problem. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.