From owner-freebsd-hackers Thu Nov 7 03:20:40 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA19355 for hackers-outgoing; Thu, 7 Nov 1996 03:20:40 -0800 (PST) Received: from dg-rtp.dg.com (dg-rtp.rtp.dg.com [128.222.1.2]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id DAA19349 for ; Thu, 7 Nov 1996 03:20:34 -0800 (PST) Received: by dg-rtp.dg.com (5.4R3.10/dg-rtp-v02) id AA21064; Thu, 7 Nov 1996 06:20:03 -0500 Received: from dg-rtp by dg-rtp.dg.com.rtp.dg.com; Thu, 7 Nov 1996 06:20 EST Received: from dg-rtp.UUCP (uucp@localhost) by ponds.water.net (8.7.5/8.7.3) with UUCP id AAA13571 for freebsd.org!freebsd-hackers; Thu, 7 Nov 1996 00:26:20 -0500 (EST) Received: from reggae.ncren.net by dg-rtp.dg.com (5.4R3.10/dg-rtp-v02) id AA28901; Wed, 6 Nov 1996 18:46:11 -0500 Received: from mcnc.UUCP by reggae.ncren.net (5.65/tas-reggae/may94) id AA22154; Wed, 6 Nov 96 18:34:48 -0500 Received: from ncnoc.ncren.net by reggae.ncren.net (5.65/tas-reggae/may94) id AA22104; Wed, 6 Nov 96 18:30:13 -0500 Received: from stingray.mcnc.org (stingray.mcnc.org [128.109.130.74]) by ncnoc.ncren.net (8.7.4/8.7.3) with ESMTP id SAA29867 for ; Wed, 6 Nov 1996 18:28:46 -0500 (EST) Received: from relay5.UU.NET by stingray.mcnc.org (8.7.5/MCNC/8-10-92) id SAA09676; Wed, 6 Nov 1996 18:27:23 -0500 (EST) for Received: from coyote.Artisoft.COM by relay5.UU.NET with ESMTP (peer crosschecked as: coyote.Artisoft.COM [198.17.250.162]) id QQbosj15364; Wed, 6 Nov 1996 18:28:23 -0500 (EST) Received: from dg-rtp.dg.com (dg-rtp.rtp.dg.com [128.222.1.2]) by coyote.Artisoft.COM (8.7.6/8.7.3) with SMTP id QAA22229 for ; Wed, 6 Nov 1996 16:20:37 -0700 (MST) Received: by dg-rtp.dg.com (5.4R3.10/dg-rtp-v02) id AA27423; Wed, 6 Nov 1996 18:20:05 -0500 Received: from ponds by dg-rtp.dg.com.rtp.dg.com; Wed, 6 Nov 1996 18:20 EST Received: from lakes.water.net (lakes [10.0.0.3]) by ponds.water.net (8.7.5/8.7.3) with ESMTP id QAA05130; Wed, 6 Nov 1996 16:08:41 -0500 (EST) Received: (from rivers@localhost) by lakes.water.net (8.7.5/8.6.9) id QAA00996; Wed, 6 Nov 1996 16:09:40 -0500 (EST) Date: Wed, 6 Nov 1996 16:09:40 -0500 (EST) From: Thomas David Rivers Message-Id: <199611062109.QAA00996@lakes.water.net> To: ponds!lambert.org!terry, ponds!uunet.uu.net!ponds!ponds!rivers Subject: Re: More info on the daily panics... Cc: ponds!uunet.uu.net!ponds!Artisoft.COM!ponds!freebsd.org!dyson, ponds!uunet.uu.net!ponds!Artisoft.COM!ponds!freebsd.org!freebsd-hackers, ponds!uunet.uu.net!ponds!Artisoft.COM!ponds!lambert.org!terry, ponds!uunet.uu.net!ponds!Artisoft.COM!ponds!rivers, ponds!uunet.uu.net!ponds!lambert.org!terry Content-Type: text Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > [ ... patch elided ... ] > > Yes. This is an equivalent workaround. > > I suppose the big question is: did this fix the problem for you? > It's been running since 9:00am this morning - if it lasts a week, I will declare it a success... > > -- > > One caution: if you do not use the macro, and the queue type is changed > yet again at some later time, this will introduce a "sneaky" bug that > will not be obvious. > > What's worse, if you are already familiar with the code, it will > "look right" because it will have been right the last time you > looked at it. > > Remember the queue type change on the mounted fs list? There was a > similar bug that "looked right" (I think that's where the macro came > from, FWIW). > > Well, in all honesty - I was too lazy to look up the macro name. But, you're right; this should be rewritten to use it... - Dave R. -