From owner-p4-projects@FreeBSD.ORG  Thu Jan  8 03:56:26 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id BA0751065672; Thu,  8 Jan 2009 03:56:25 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 79944106566C
	for <perforce@FreeBSD.org>; Thu,  8 Jan 2009 03:56:25 +0000 (UTC)
	(envelope-from weongyo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 685658FC0A
	for <perforce@FreeBSD.org>; Thu,  8 Jan 2009 03:56:25 +0000 (UTC)
	(envelope-from weongyo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n083uPgp027522
	for <perforce@FreeBSD.org>; Thu, 8 Jan 2009 03:56:25 GMT
	(envelope-from weongyo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n083uPY0027520
	for perforce@freebsd.org; Thu, 8 Jan 2009 03:56:25 GMT
	(envelope-from weongyo@FreeBSD.org)
Date: Thu, 8 Jan 2009 03:56:25 GMT
Message-Id: <200901080356.n083uPY0027520@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	weongyo@FreeBSD.org using -f
From: Weongyo Jeong <weongyo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 155798 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jan 2009 03:56:27 -0000

http://perforce.freebsd.org/chv.cgi?CH=155798

Change 155798 by weongyo@weongyo_ws on 2009/01/08 03:55:24

	As a looking of the Realtek's linux driver they use RX_MAXSIZE buffers
	with 0x9c4(2500) but currently urtw(4) would use MCLBYTES.  Without
	datasheets it looks hard to define the value exactly.  Just with some
	testing it looks it's ok to use MCLBYTES but not sure there're some
	side-effects.
	
	So temporary remove a warning message to make users into confusions.

Affected files ...

.. //depot/projects/vap/sys/dev/usb/if_urtw.c#14 edit

Differences ...

==== //depot/projects/vap/sys/dev/usb/if_urtw.c#14 (text+ko) ====

@@ -669,7 +669,6 @@
 			goto fail;
 		}
 		if (fillmbuf) {
-			/* XXX check maxsz */
 			dp->m = m_getcl(M_DONTWAIT, MT_DATA, M_PKTHDR);
 			if (dp->m == NULL) {
 				device_printf(sc->sc_dev,
@@ -734,9 +733,6 @@
 urtw_alloc_rx_data_list(struct urtw_softc *sc)
 {
 
-	/* XXX todo  */
-	device_printf(sc->sc_dev, "WARNING: rx buffer is smaller than %d\n",
-	    URTW_RX_MAXSIZE);
 	return urtw_alloc_data_list(sc,
 	    sc->sc_rxdata, URTW_RX_DATA_LIST_COUNT, MCLBYTES, 1 /* mbufs */);
 }