From owner-cvs-all  Thu Dec 10 22:02:07 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id WAA19779
          for cvs-all-outgoing; Thu, 10 Dec 1998 22:02:07 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA19773;
          Thu, 10 Dec 1998 22:02:05 -0800 (PST)
          (envelope-from julian@FreeBSD.org)
From: Julian Elischer <julian@FreeBSD.ORG>
Received: (from julian@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id WAA26679;
	Thu, 10 Dec 1998 22:02:06 -0800 (PST)
Date: Thu, 10 Dec 1998 22:02:06 -0800 (PST)
Message-Id: <199812110602.WAA26679@freefall.freebsd.org>
To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: cvs commit: src/sys/dev/usb ohci.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

julian      1998/12/10 22:02:06 PST

  Modified files:
    sys/dev/usb          ohci.c 
  Log:
  If we failed to probe/attach somehow, we never have a sc->sc_hcca
  but the present PCI probe code still thinks we are there as the pci attach
  can't return an error code.
  
  This means we are in the shared interrupt list, but have not been set up.
  If we are sharing ints with another device, ohci_intr will be called and will
  coredump on a NULL reference. So just return if it is called when not set up.
  
  This fixes the symptom and not the cause.
  The right answer is to let the PCI system know that the attach failed,
  or to fail earlier (in the PCI probe).
  The attach() is a void fn() so it can't return failure..
  
  Revision  Changes    Path
  1.2       +3 -0      src/sys/dev/usb/ohci.c

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message