From owner-svn-src-head@freebsd.org Wed Aug 12 16:19:13 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6A76F3A495C for ; Wed, 12 Aug 2020 16:19:13 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BRZdr2Yhrz46H3 for ; Wed, 12 Aug 2020 16:19:12 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f48.google.com with SMTP id x5so2289681wmi.2 for ; Wed, 12 Aug 2020 09:19:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Oh5LIFHNxMbIWKKM12807jQt1Vox5W2OFYkydDDTJTI=; b=qy0wzm+Rp4EtB04nLXipwHBsoJ4deNAhRnocyaEM4WzLDJXqYhk3g/N9ZTFk5nLP6s UwKIkGR/6pqjoKtS8ZPAqR3n0Rd11KHPImyJZkLel5N/ATHt8iAqOVUDbJvklim+RYo/ q2f/UIqYeNPewBQGl8c4L8oBXtqcuz/Fma7vhSFLwP/L+KgFlNnjY71E3o9WwNh5QSeZ ZKmdRKHOQHy9Z0BwdcEjuAnHaBobSMbz5ZHnG1p5NFGxf5G0vuMrgIX/LSbSRCvcAMED 5hJc0D5hr1mAYfPCeAFW52b+GHZD/8y1C0Ny39t9iO14dDovVarLXRon3fPrhvyzdOwM KGdA== X-Gm-Message-State: AOAM533xPzd6IHooxx8RCvBiMIDRV7kiWx2FF4fGt0gY0EsTRKqnXybk UtXWUhxbWnVZyKpdIwZ19Rpc7w== X-Google-Smtp-Source: ABdhPJwPFEf2EBAaAoZsPVfUPbGIV2hgvsmO3LiCuVy/UajdF+EEkmiiaUE+uJojFm2MOVhWOCwkEw== X-Received: by 2002:a7b:c056:: with SMTP id u22mr451801wmc.188.1597249150795; Wed, 12 Aug 2020 09:19:10 -0700 (PDT) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id 6sm4522020wmf.4.2020.08.12.09.19.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Aug 2020 09:19:10 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: svn commit: r364166 - head/usr.sbin/crunch/crunchgen From: Jessica Clarke In-Reply-To: <202008121610.07CGAcm0038791@gndrsh.dnsmgr.net> Date: Wed, 12 Aug 2020 17:19:02 +0100 Cc: Alex Richardson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <32E49245-77B0-4E61-A483-9F7B34D939B7@freebsd.org> References: <202008121610.07CGAcm0038791@gndrsh.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3608.120.23.2.1) X-Rspamd-Queue-Id: 4BRZdr2Yhrz46H3 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-1.61 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.02)[-1.020]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.05)[-0.047]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.48:from]; NEURAL_HAM_MEDIUM(-1.04)[-1.039]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.48:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2020 16:19:13 -0000 On 12 Aug 2020, at 17:10, Rodney W. Grimes = wrote: >=20 > [ Charset UTF-8 unsupported, converting... ] >> Author: arichardson >> Date: Wed Aug 12 15:49:06 2020 >> New Revision: 364166 >> URL: https://svnweb.freebsd.org/changeset/base/364166 >>=20 >> Log: >> Fix crunchgen usage of mkstemp() >>=20 >> On Glibc systems mkstemp can only be used once with the same = template >> string since it will be modified in-place and no longer contain any = 'X' chars. >> It is fine to reuse the same file here but we need to be explicit = and use >> open() instead of mkstemp() on the second use. >>=20 >> While touching this file also avoid a hardcoded /bin/pwd since that = may not >> work when building on non-FreeBSD systems. >=20 > This may cause some grief, as now pwd may use a shell builtin > and often shell builtin's return a cwd that is not a true > full path, ie it may contain symlink compontents in the > path. >=20 > /bin/sh: >=20 > # cd /tmp/b > # /bin/pwd > /tmp/a > # pwd > /tmp/b > # ls -lag /tmp/? > lrwxr-xr-x 1 root wheel 1 Aug 12 16:06 /tmp/b -> a >=20 > /tmp/a: > total 17 > drwxr-xr-x 2 root wheel 2 Aug 12 16:06 . > drwxrwxrwt 18 root wheel 248 Aug 12 16:06 .. There's the question of whether that really matters; both values are in some sense correct. But if you want to restore the old behaviour, I believe `env pwd` is the portable way to do so? Jess