From owner-freebsd-python@FreeBSD.ORG Wed Apr 11 20:00:40 2012 Return-Path: Delivered-To: freebsd-python@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D0B13106566C for ; Wed, 11 Apr 2012 20:00:40 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BB40E8FC14 for ; Wed, 11 Apr 2012 20:00:40 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3BK0eTO009367 for ; Wed, 11 Apr 2012 20:00:40 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3BK0eHF009364; Wed, 11 Apr 2012 20:00:40 GMT (envelope-from gnats) Date: Wed, 11 Apr 2012 20:00:40 GMT Message-Id: <201204112000.q3BK0eHF009364@freefall.freebsd.org> To: freebsd-python@FreeBSD.org From: John Hein Cc: Subject: Re: ports/159215: Mk/bsd.python.mk: PYTHON_VERSION is ignored X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John Hein List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2012 20:00:40 -0000 The following reply was made to PR ports/159215; it has been noted by GNATS. From: John Hein To: Mel Flynn Cc: Ruslan Mahmatkhanov , , , , Subject: Re: ports/159215: Mk/bsd.python.mk: PYTHON_VERSION is ignored Date: Wed, 11 Apr 2012 13:55:25 -0600 Mel Flynn wrote at 21:47 +0200 on Apr 11, 2012: > On 4/11/2012 21:22, John Hein wrote: > > > But (#1) neither work because bsd.port.pre.mk defines PYTHON_PORTSDIR > > before the new python version can be set by the ARCH == amd64 test. > > > > But (#2) you can't put the ARCH .if test before bsd.port.pre.mk since > > ARCH is not defined at that point. > > Just a thought: > You can simplify the hack by including bsd.port.options.mk instead of > the first bsd.port.pre.mk. ARCH will be defined while bsd.python.mk > isn't included yet. Indeed. Although it's a bit counterintuitive to include bsd.port.options.mk when there are no OPTIONS. However, it's perhaps safer than including pre.mk twice and hoping no one changes anything above the first that leaves USE_PYTHON defined. Whichever of those hacks is used, there should be a comment about what's going on and why.