Date: Wed, 11 Apr 2012 20:00:40 GMT From: John Hein <jhein@symmetricom.com> To: freebsd-python@FreeBSD.org Subject: Re: ports/159215: Mk/bsd.python.mk: PYTHON_VERSION is ignored Message-ID: <201204112000.q3BK0eHF009364@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/159215; it has been noted by GNATS.
From: John Hein <jhein@symmetricom.com>
To: Mel Flynn <rflynn@acsalaska.net>
Cc: Ruslan Mahmatkhanov <cvs-src@yandex.ru>, <freebsd-python@freebsd.org>,
<mexas@bristol.ac.uk>, <bug-followup@freebsd.org>, <miwi@freebsd.org>
Subject: Re: ports/159215: Mk/bsd.python.mk: PYTHON_VERSION is ignored
Date: Wed, 11 Apr 2012 13:55:25 -0600
Mel Flynn wrote at 21:47 +0200 on Apr 11, 2012:
> On 4/11/2012 21:22, John Hein wrote:
>
> > But (#1) neither work because bsd.port.pre.mk defines PYTHON_PORTSDIR
> > before the new python version can be set by the ARCH == amd64 test.
> >
> > But (#2) you can't put the ARCH .if test before bsd.port.pre.mk since
> > ARCH is not defined at that point.
>
> Just a thought:
> You can simplify the hack by including bsd.port.options.mk instead of
> the first bsd.port.pre.mk. ARCH will be defined while bsd.python.mk
> isn't included yet.
Indeed. Although it's a bit counterintuitive to include
bsd.port.options.mk when there are no OPTIONS. However, it's perhaps
safer than including pre.mk twice and hoping no one changes anything
above the first that leaves USE_PYTHON defined.
Whichever of those hacks is used, there should be a comment about
what's going on and why.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204112000.q3BK0eHF009364>