From owner-freebsd-emulation@freebsd.org Sat May 23 19:53:06 2020 Return-Path: Delivered-To: freebsd-emulation@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 197F12DC7FC for ; Sat, 23 May 2020 19:53:06 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49TvD10ty6z4YwZ for ; Sat, 23 May 2020 19:53:04 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 3E28533E45; Sat, 23 May 2020 15:53:04 -0400 (EDT) Received: from [192.168.1.5] (unknown [77.118.196.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 90D0933E1E; Sat, 23 May 2020 15:53:03 -0400 (EDT) Date: Sat, 23 May 2020 21:52:48 +0200 (CEST) From: Gerald Pfeifer To: Damjan Jovanovic cc: freebsd-emulation@freebsd.org Subject: Re: Wine 5.9 bugfix In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 49TvD10ty6z4YwZ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-2.97 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.04)[-1.036]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; NEURAL_HAM_LONG(-0.99)[-0.991]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.64)[-0.641]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[] X-Mailman-Approved-At: Sun, 24 May 2020 07:45:38 +0000 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2020 19:53:06 -0000 On Sat, 23 May 2020, Damjan Jovanovic wrote: > Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting > FreeBSD should be fixed upstream now. Thank you for debugging and even fixing those, Damjan - and even doing so upstream! > However I accidentally introduced another bug recently, where we don't > check the return value from an mmap() call, resulting in assertion failures > and possibly memory corruption... I debugged it and a patch to fix it is > available (https://source.winehq.org/patches/data/185684). Please build > ports with that patch applied to 5.9. Sorry. I just started test builds of emulators/wine-devel with that patch. So far I have kept files/patch-tools-winegcc which reverts the upstream change (1ccd638b1aa85fb3c43b49d69d279cd509ebdc21) that kicked of this avalanche of events. I was thinking to keep that as part of our port until the next snapshot (Wine 5.10) - do you have any strong feelings or recommendations either way? Thanks, Gerald