From owner-svn-src-all@FreeBSD.ORG  Tue Mar 30 03:29:12 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BBBB9106566C;
	Tue, 30 Mar 2010 03:29:12 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail05.syd.optusnet.com.au (mail05.syd.optusnet.com.au
	[211.29.132.186])
	by mx1.freebsd.org (Postfix) with ESMTP id 38B388FC16;
	Tue, 30 Mar 2010 03:29:11 +0000 (UTC)
Received: from c122-106-158-90.carlnfd1.nsw.optusnet.com.au
	(c122-106-158-90.carlnfd1.nsw.optusnet.com.au [122.106.158.90])
	by mail05.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	o2U3T5cZ020977
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 30 Mar 2010 14:29:10 +1100
Date: Tue, 30 Mar 2010 14:29:05 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Dag-Erling Smorgrav <des@freebsd.org>
In-Reply-To: <201003291320.o2TDKqfe066476@svn.freebsd.org>
Message-ID: <20100330142351.C5481@delplex.bde.org>
References: <201003291320.o2TDKqfe066476@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r205834 - head/usr.bin/calendar
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2010 03:29:12 -0000

On Mon, 29 Mar 2010, Dag-Erling Smorgrav wrote:

> Log:
>  size_t is not equivalent to int on 64-bit platforms.

Neither is it on 16-63 or 65-infinity bit platforms, since it is not signed.

> Modified: head/usr.bin/calendar/parsedata.c
> ==============================================================================
> --- head/usr.bin/calendar/parsedata.c	Mon Mar 29 12:32:16 2010	(r205833)
> +++ head/usr.bin/calendar/parsedata.c	Mon Mar 29 13:20:52 2010	(r205834)
> @@ -39,9 +39,9 @@ __FBSDID("$FreeBSD$");
> static char *showflags(int flags);
> static int isonlydigits(char *s, int nostar);
> static const char *getmonthname(int i);
> -static int checkmonth(char *s, int *len, int *offset, const char **month);
> +static int checkmonth(char *s, size_t *len, size_t *offset, const char **month);
> static const char *getdayofweekname(int i);
> -static int checkdayofweek(char *s, int *len, int *offset, const char **dow);
> +static int checkdayofweek(char *s, size_t *len, size_t *offset, const char **dow);

len("size_t") is not equivalent to len("int") so s/size_t/int/g gives
ugly formatting on some platforms.

Bruce