From owner-svn-src-head@FreeBSD.ORG Wed Jul 1 15:52:29 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E9A61065739; Wed, 1 Jul 2009 15:52:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1BA668FC25; Wed, 1 Jul 2009 15:52:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id A7ABA46B9C; Wed, 1 Jul 2009 11:52:26 -0400 (EDT) Received: from John-Baldwins-Macbook-Pro.local (localhost [IPv6:::1]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 9AE318A08C; Wed, 1 Jul 2009 11:52:24 -0400 (EDT) Message-ID: <4A4B863A.7090304@FreeBSD.org> Date: Wed, 01 Jul 2009 11:52:26 -0400 From: John Baldwin User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: Steve Kargl References: <200906300318.n5U3Ipr4066645@svn.freebsd.org> <20090630051641.T22887@maildrop.int.zabbadoz.net> <20090630144904.GA41936@troutmask.apl.washington.edu> In-Reply-To: <20090630144904.GA41936@troutmask.apl.washington.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 01 Jul 2009 11:52:25 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, dfr@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, bz0fbd@zabbadoz.net Subject: Re: svn commit: r195181 - in head/sys: nfsclient nfsserver X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2009 15:52:29 -0000 Steve Kargl wrote: > On Tue, Jun 30, 2009 at 05:17:48AM +0000, bz0fbd@zabbadoz.net wrote: >> On Tue, 30 Jun 2009, John Baldwin wrote: >> >>> Author: jhb >>> Date: Tue Jun 30 03:18:51 2009 >>> New Revision: 195181 >>> URL: http://svn.freebsd.org/changeset/base/195181 >>> >>> Log: >>> Fix build with NFS_LEGACYRPC enabled after the socket upcall locking >>> changes. >> is this really a good idea, considering that NFS_LEGACYRPC is on the >> "removal list" for 8.0? > > Yes. > > 1) This option definitely worked on April 18th. > 2) The option was broken by a commit that was never tested! If anything > this should remind committers to either get a code review or test > their patch. That isn't a completely fair assessment. The patch was most certainly tested with NFS in the default configuration (!NFS_LEGACYRPC). It is also a good idea to fix the option until such time as it is formally removed, however. -- John Baldwin