From owner-svn-src-head@FreeBSD.ORG Fri Dec 28 20:31:32 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EAD90622; Fri, 28 Dec 2012 20:31:31 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by mx1.freebsd.org (Postfix) with ESMTP id 23EFF8FC13; Fri, 28 Dec 2012 20:31:30 +0000 (UTC) Received: by mail-wg0-f51.google.com with SMTP id gg4so4821649wgb.18 for ; Fri, 28 Dec 2012 12:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=nak0jeBCOm/tpanl1lQYEvdJFt6sV6KTqBREQ6PimJ8=; b=pRLl3ormazihvcj2S2+/4rCdg0ODY8282gzVxLueQ6ISyd9+r6678byWfGZEwIP2Rx rzbn+KlhSV1W6PXckd7dCSRHEgpcKf9AyS+fpawRLhsM+gxXVWcMpWkzRh5QEge8GNpd Sn8NvASMLWXU+kJxIgkCNbKtreODyXnydApwqI+MV58bsLp4+1IKqKbmFnluM1bEkvZz z3eH4slGyLSyfBceIL1uww2AuVGvwQ+W+g7kNLq05Ng7WDahVMLYpKvTGZkuj6m7v5TE 6nWdO15Y77w1JGetiMO+97ejFVObbOCxr9Pe5SspUvcmSXjw7dhCXuCcsEFKwf6RRTXk qvIA== X-Received: by 10.180.82.69 with SMTP id g5mr54775118wiy.21.1356726690055; Fri, 28 Dec 2012 12:31:30 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id i2sm63747483wiw.3.2012.12.28.12.31.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 28 Dec 2012 12:31:29 -0800 (PST) Sender: Baptiste Daroussin Date: Fri, 28 Dec 2012 21:31:28 +0100 From: Baptiste Daroussin To: Garrett Cooper Subject: Re: svn commit: r244778 - head/lib/libutil Message-ID: <20121228203128.GF48771@ithaqua.etoilebsd.net> References: <201212282021.qBSKLEeG096326@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O98KdSgI27dgYlM5" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2012 20:31:32 -0000 --O98KdSgI27dgYlM5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 28, 2012 at 12:22:54PM -0800, Garrett Cooper wrote: > On Fri, Dec 28, 2012 at 12:21 PM, Baptiste Daroussin w= rote: > > Author: bapt > > Date: Fri Dec 28 20:21:14 2012 > > New Revision: 244778 > > URL: http://svnweb.freebsd.org/changeset/base/244778 > > > > Log: > > malloc() sets errno to ENOMEM already. > > > > Submitted by: Christoph Mallon > > > > Modified: > > head/lib/libutil/gr_util.c > > > > Modified: head/lib/libutil/gr_util.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libutil/gr_util.c Fri Dec 28 20:19:54 2012 (r24477= 7) > > +++ head/lib/libutil/gr_util.c Fri Dec 28 20:21:14 2012 (r24477= 8) > > @@ -505,17 +505,13 @@ gr_add(struct group *gr, char *newmember > > } > > /* Allocate enough for current pointers + 1 more and NULL marke= r */ > > mlen =3D (num_mem + 2) * sizeof(*gr->gr_mem); > > - if ((members =3D malloc(mlen)) =3D=3D NULL) { > > + if ((members =3D malloc(mlen)) =3D=3D NULL) > > errno =3D ENOMEM; > > - return (NULL); > > - } >=20 > Didn't you mean to remove errno =3D ENOMEM? Thank you, fixed. Bapt --O98KdSgI27dgYlM5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDeAZ8ACgkQ8kTtMUmk6Ez1EQCfRLU5vTJV4Si+uPqrHavpobDE oKgAn2Gg4w7uXdSrKUQ/KT+Dzb+Wu/Vo =8zd5 -----END PGP SIGNATURE----- --O98KdSgI27dgYlM5--