From owner-svn-src-stable@freebsd.org  Sat May 12 00:54:23 2018
Return-Path: <owner-svn-src-stable@freebsd.org>
Delivered-To: svn-src-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A5FBFD825B;
 Sat, 12 May 2018 00:54:23 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A413686795;
 Sat, 12 May 2018 00:54:22 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 62331203CE;
 Sat, 12 May 2018 00:54:22 +0000 (UTC) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: "Jonathan T. Looney" <jtl@freebsd.org>
Cc: Stephen Hurd <shurd@freebsd.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject: Re: svn commit: r333503 - stable/11/sys/net
Date: Fri, 11 May 2018 17:24:20 -0700
Message-ID: <2564916.ivnyjH5XrP@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; )
In-Reply-To: <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com>
References: <201805112040.w4BKeQvO053076@repo.freebsd.org>
 <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-stable>, 
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 May 2018 00:54:23 -0000

On Friday, May 11, 2018 07:31:40 PM Jonathan T. Looney wrote:
> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd@freebsd.org> wrote:
> >
> > Author: shurd
> > Date: Fri May 11 20:40:26 2018
> > New Revision: 333503
> > URL: https://svnweb.freebsd.org/changeset/base/333503
> >
> > Log:
> >   MFC r333329, r333366, r333373
> >
> >   r333329: Fix off-by-one error requesting tx interrupt
> >   r333366: Cleanup queues when iflib_device_register fails
> >   r333373: Log iflib_tx_structures_setup failure in function
> >
> 
> Is this an acceptable style for MFC logs?
> 
> I'm asking because I actually prefer this to reading (or compiling) the
> concatenated log messages from several changes. However, I never knew it
> was acceptable to summarize like this. If it is, I'd like to know so I can
> adopt it for run-of-the-mill MFCs.

I prefer to summarize myself, but others have complained that you then
can't grep for strings used in the head commit log to determine if a
change has been MFC'd (assuming you don't have the head rev handy and
want to search by some name / string you remember).  In particular I
preferred doing a "squash" of fixup type commits when doing MFCs, but
I've relented to doing the full logs.

-- 
John Baldwin