From owner-cvs-src@FreeBSD.ORG Sun Dec 26 18:30:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 87DE416A4CE; Sun, 26 Dec 2004 18:30:15 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5059143D54; Sun, 26 Dec 2004 18:30:15 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] (sam@[66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id iBQIU9Wi027450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 26 Dec 2004 10:30:10 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <41CF0326.9090704@errno.com> Date: Sun, 26 Dec 2004 10:29:58 -0800 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Darren Reed References: <200412250048.iBP0mSto090429@repoman.freebsd.org> <20041226083448.GA93350@hub.freebsd.org> <20041226144953.GB93350@hub.freebsd.org> In-Reply-To: <20041226144953.GB93350@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: Dag-Erling Sm?rgrav cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet ip_fil.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Dec 2004 18:30:15 -0000 Darren Reed wrote: > On Sun, Dec 26, 2004 at 01:40:40PM +0100, Dag-Erling Sm?rgrav wrote: > >>Darren Reed writes: >> >>>Sorry about breaking HEAD builds, some patches got left behind when >>>I generated diffs and took them across to the freebsd tree :( >> >>You would have caught that if you'd tried to build before committing. > > > And what if I said I did? I think what you're trying to say is build what > you intend to commit before you commit. I don't have the luxury of having > systems around that i can keep upto date with each of 4-stable and 5-stable > and -current, as well as the latest 4.x and 5.x release (what users use.) > I believe you can cross-build from a system you have, but I cannot tell from the above what systems you actually run. > >>You seem to fail to do that with appalling regularity. > > > It's unfortunate that it happens but it does. > > I wish the solution was as easy as your implied suggestion but, > sorry, it isn't. Have you considered finding another committer to take responsibility for this code? If you can't run an up to date current system to validate changes (not just compilation but also stability in operation) then it sounds like there will continue to be problems. Sam