From owner-cvs-all@FreeBSD.ORG  Sun Aug 21 11:49:08 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EF482106566C;
	Sun, 21 Aug 2011 11:49:08 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-iy0-f172.google.com (mail-iy0-f172.google.com
	[209.85.210.172])
	by mx1.freebsd.org (Postfix) with ESMTP id 854F18FC0A;
	Sun, 21 Aug 2011 11:49:08 +0000 (UTC)
Received: by iye7 with SMTP id 7so16588888iye.17
	for <multiple recipients>; Sun, 21 Aug 2011 04:49:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type
	:content-transfer-encoding;
	bh=O7FCGBm1XhciRz0OpibGiZe+cCdwrV0xPJwatATwiTU=;
	b=fdFYNEdYXNYaKZMxKDmy0ZValCp5VIHtxDfDuxTy+Xl/muXFAR6ka7e/ucL3DH4KWq
	yLBQUqxkAGvqpE/boZZUu1P+oOYkeYa18ak1AwurVl6BPiXhHHZKyyZb4Ra6oFo0Z9pR
	Mw/YuP+T5EGBD9Z+ETWfSGeKY3m+ZRrQ9Es4s=
Received: by 10.231.4.99 with SMTP id 35mr3164515ibq.85.1313927348102; Sun, 21
	Aug 2011 04:49:08 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.231.182.77 with HTTP; Sun, 21 Aug 2011 04:48:38 -0700 (PDT)
In-Reply-To: <20110821114454.GA77777@FreeBSD.org>
References: <201108211100.p7LB0cB7060742@repoman.freebsd.org>
	<CADLo838r7ksFKTjB24NBVTtnyDaf54jdz9aQ9Ggb22CtsvA9ng@mail.gmail.com>
	<20110821114454.GA77777@FreeBSD.org>
From: Chris Rees <crees@freebsd.org>
Date: Sun, 21 Aug 2011 12:48:38 +0100
X-Google-Sender-Auth: tt5LHCow_t1GAMIYnfjUrLTleYQ
Message-ID: <CADLo83-G2ofiaLZiTA_+B2FBTAw-AUw2+GHWfEo+Mno7QJXeRQ@mail.gmail.com>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/www/chromium Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Aug 2011 11:49:09 -0000

2011/8/21 Alexey Dokuchaev <danfe@freebsd.org>:
> On Sun, Aug 21, 2011 at 12:04:37PM +0100, Chris Rees wrote:
>> On 21 August 2011 12:00, Rene Ladan <rene@freebsd.org> wrote:
>> > rene =A0 =A0 =A0 =A02011-08-21 11:00:38 UTC
>> >
>> > =A0Modified files:
>> > =A0 =A0www/chromium =A0 =A0 =A0 =A0 Makefile
>> > =A0Log:
>> > =A0Do not hardcode the patch directory as "files", use ${FILESDIR} ins=
tead.
>>
>> Shouldn't it be PATCHDIR?
>
> Ideally, only one should stay, I don't really care which one (although
> FILESDIR is maybe a bit better as it's more generic -- there might be not
> only patches, but drop-in files, etc).
>
> I wanted to look at merging FILESDIR/PATCHDIR logic in bpm several years
> ago, but didn't go much further.
>

I'd agree on FILESDIR.

Anyone have a problem with adding a section on
wiki/PortsLongtermTargets about ports that use PATCHDIR? This
inconsistency is a little strange.

Chris