Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2019 14:07:32 -0000
From:      Enji Cooper <yaneurabeya@gmail.com>
To:        Alexander Motin <mav@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <0F708A9C-D29D-466A-B541-06DB7127349E@gmail.com>
In-Reply-To: <201904191544.x3JFijLe075969@repo.freebsd.org>
References:  <201904191544.x3JFijLe075969@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Apr 19, 2019, at 08:44, Alexander Motin <mav@freebsd.org> wrote:
>=20
> Author: mav
> Date: Fri Apr 19 15:44:45 2019
> New Revision: 346390
> URL: https://svnweb.freebsd.org/changeset/base/346390
>=20
> Log:
>  Change the way FreeBSD GID inheritance is hacked.
>=20
>  I believe previous ifdef caused NULL dereference in later zfs_log_create(=
)
>  on attempt to create file inside directory belonging to ephemeral group
>  created on illumos, trying to write to log information about GID domain
>  of the newly created file, inheriting the ephemeral GID.
>=20
>  This patch reuses original illumos SGID code with exception that due to
>  lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBOD=
Y
>  by another ifdef inside zfs_fuid_map_id().

Hi mav@!
    I was wondering, does this break ACL mappings with sticky bits for the g=
roup ID (or was it broken to begin with)? If the latter, does it make sense t=
o file a bug/add a TODO comment?
Thank you!
-Enji=





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0F708A9C-D29D-466A-B541-06DB7127349E>