From owner-freebsd-current@freebsd.org Sat Jun 2 18:30:42 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C0E9FD0277; Sat, 2 Jun 2018 18:30:42 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id D544170EDA; Sat, 2 Jun 2018 18:30:41 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id 1E66E20490; Sat, 2 Jun 2018 21:30:36 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id 16D-rOIu57KM; Sat, 2 Jun 2018 21:30:21 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id 3F42920484; Sat, 2 Jun 2018 21:30:21 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id 7733E422129; Sat, 2 Jun 2018 21:30:17 +0300 (MSK) X-Virus-Scanned: amavisd-new at cicgroup.ru Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id hCOmoX2Hapx3; Sat, 2 Jun 2018 21:30:10 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTPA id 1D0A9422128; Sat, 2 Jun 2018 21:30:10 +0300 (MSK) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 02 Jun 2018 21:30:09 +0300 From: Vladimir Kondratyev To: Allan Jude Cc: freebsd-current@freebsd.org, owner-freebsd-current@freebsd.org Subject: Re: Proper way to remove never used ioctls In-Reply-To: References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> Message-ID: <8f0bd4c0195ecaf1038268831576c461@kondratyev.su> X-Sender: vladimir@kondratyev.su User-Agent: Roundcube Webmail/1.3.5 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2018 18:30:42 -0000 On 2018-06-02 20:36, Allan Jude wrote: > On 2018-06-02 11:03, Warner Losh wrote: >> On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev >> >> wrote: >> >>> Hi, >>> >>> Our sys/mouse.h header has a definition of MOUSE_GETVARS and >>> MOUSE_SETVARS >>> ioctls which are not documented and only stubbed in a few drivers: >>> mse(4), >>> psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS >>> implemented in psm(4) >>> >>> Given the fact that they were introduced 20 years ago, implementation >>> was >>> never completed and googling on them shows no traces of usage in >>> indexed >>> universe, is it acceptable to just drop both defines and >>> implementation >>> w.o. leaving any COMPAT_FREEBSD shims? >> >> >> I'd prepare a patch just removing them. I'd then send that patch to >> the >> ports mgr team and request a exp-run. Details for that can be found in >> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html >> >> Once that's done, submit a Phabricator review and send me email. I'll >> make >> sure it gets pushed in if there's no objections. >> >> Warner > > This indeed seems to be the correct approach. The exp-run will compile > the entire ports tree against the patched base system, and identify any > 3rd party software that fails to compile because of the change. Thank you, Allan and Warner! I'll follow yours advice. -- WBR Vladimir Kondratyev