From owner-cvs-src@FreeBSD.ORG Tue Feb 15 01:53:26 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 599B116A4CE; Tue, 15 Feb 2005 01:53:26 +0000 (GMT) Received: from out001.verizon.net (out001pub.verizon.net [206.46.170.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id A281443D31; Tue, 15 Feb 2005 01:53:25 +0000 (GMT) (envelope-from babkin@bellatlantic.net) Received: from bellatlantic.net ([138.89.158.160]) by out001.verizon.net (InterMail vM.5.01.06.06 201-253-122-130-106-20030910) with ESMTP id <20050215015315.BKAW29541.out001.verizon.net@bellatlantic.net>; Mon, 14 Feb 2005 19:53:15 -0600 Sender: root@FreeBSD.ORG Message-ID: <421155CF.DC261239@bellatlantic.net> Date: Mon, 14 Feb 2005 20:52:15 -0500 From: Sergey Babkin X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 4.7-RELEASE i386) X-Accept-Language: en, ru MIME-Version: 1.0 To: "M. Warner Losh" References: <20050211220212.A32327@delplex.bde.org> <20050211.091716.32469757.imp@bsdimp.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Authentication-Info: Submitted using SMTP AUTH at out001.verizon.net from [138.89.158.160] at Mon, 14 Feb 2005 19:52:34 -0600 cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: rizzo@icir.org cc: cvs-all@FreeBSD.org cc: phk@phk.freebsd.dk cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ed if_ed.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Feb 2005 01:53:26 -0000 "M. Warner Losh" wrote: > > In message: <10137.1108121831@critter.freebsd.dk> > "Poul-Henning Kamp" writes: > : Writing "continue" dispells any doubt if I did it intentionally. > > There are also compilers that will issue warnings for while (xxxx);, > but not for while (xxx) continue;, which is where I picked up the > habit in the deep, recesses of time... Recently I've picked another style which I like now better than anything I've seen before: while(xxxx) { } The "{ }" is more meaty than just a ";" yet it communicates very clearly that it's an empty loop body. (I've picked it from the style of C++ constructor with empty body, but I like it for the loops as well). -SB