From owner-svn-src-all@freebsd.org Tue Oct 27 18:52:53 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5D303458001; Tue, 27 Oct 2020 18:52:53 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLLS42Pk7z42dh; Tue, 27 Oct 2020 18:52:52 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f65.google.com with SMTP id b15so2674365iod.13; Tue, 27 Oct 2020 11:52:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YdAjmuZOnvPUiDWAOOG0WyYDBf8CSyJdbIEb4Ye9j1Q=; b=IqnnvRQN7srGPhM7EnAx20diZ1/tQ8g6SHTorm8Qp79RJQqJ2HSi3Hulc7PQMpaPt5 aJ1/Ox8ffe3KWzfDP9NQMStaZ8vqKobu5X+lHxFfVF/7qrigKlhkkWWFroHvSJhepjb5 s0oQ5hqdCGCJBkjmsPAJRfegUR1igLqu2lThBlD4Q5cOi7XH4/zgBN1aFUWkjb2UJdoM BNqrN+Fg3tuDfHV0NuH1V2L6lnQy2zydPLc1n9Z+Imtnq2PnUOSChZCf+NH0QguS1ASu nNvJ1O60eQLaFxQVU4Gf4MeQ61m0MQaxF7ygIuk/ac7Av1qVNbd1v6pdMyBam1vwqH4T FgNQ== X-Gm-Message-State: AOAM532Pnj+bMnei3asgOuwiBA09ypJ4v6zl4xlcia00wTbA1lOtjgnd kbOC5slAHCMRp7nsqisQTJVGN6SF0XAfCwvgQ8U= X-Google-Smtp-Source: ABdhPJx7qJjezUo9077ZJeOajSrGOGgm+/aMOfkvLlMWEoIEydfsaxaR0wdm55UrTc6lU0r62xBgv6Zyu3HtL0QUqOM= X-Received: by 2002:a5e:dc0b:: with SMTP id b11mr3463999iok.179.1603824770866; Tue, 27 Oct 2020 11:52:50 -0700 (PDT) MIME-Version: 1.0 References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024104628.GB2643@kib.kiev.ua> In-Reply-To: <20201024104628.GB2643@kib.kiev.ua> From: Ed Maste Date: Tue, 27 Oct 2020 14:52:38 -0400 Message-ID: Subject: Re: svn commit: r366993 - head/sys/net To: Konstantin Belousov Cc: Hans Petter Selasky , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CLLS42Pk7z42dh X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.65 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-1.62 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[carpeddiem]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-0.91)[-0.906]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.973]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.65:from]; NEURAL_SPAM_SHORT(0.26)[0.258]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.65:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 18:52:53 -0000 On Sat, 24 Oct 2020 at 06:46, Konstantin Belousov wrote: > > > -#include > sys/systm.h should come right after sys/param.h. These two headers are > exceptions to the normal alphabetical rule. style(9) claims that sys/types.h and sys/param.h are the special headers: Kernel include files (sys/*.h) come first. If is needed for __FBSDID(), include it first. If either or is needed, include it before other include files. ( includes ; do not include both.) The remaining kernel headers should be sorted alphabetically. We should add sys/systm.h to style(9) as another special case if necessary. > > -infiniband_ipv4_multicast_map(uint32_t addr, > > - const uint8_t *broadcast, uint8_t *buf) > > +infiniband_ipv4_multicast_map( > > + uint32_t addr, const uint8_t *broadcast, uint8_t *buf) > And this is arguably regression, we fill line up to columns 72-80 before > splitting to the continuation line. I agree with kib and arichardson has a clang-format fix for this in D26978. That said I can see an argument for it being easier to read with all function args on the same line. > > - m = NULL; /* mbuf is consumed by resolver */ > > + m = NULL; /* mbuf is consumed by resolver */ > This is a regression as well, in-line comment is typically preceeded by tab. I suspect this is hard to do in an automated fashion in a way that's sensible overall (i.e., lining up inline comments on different lines). This could be a case where we decide to just accept it when someone uses clang-format on new code, and just discourage sweeping clang-format changes on existing code.