From owner-freebsd-bugs  Sat Jan 18  9:50: 5 2003
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5B49F37B401
	for <freebsd-bugs@hub.freebsd.org>; Sat, 18 Jan 2003 09:50:03 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 72C9143F18
	for <freebsd-bugs@hub.freebsd.org>; Sat, 18 Jan 2003 09:50:02 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h0IHo2NS086734
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 18 Jan 2003 09:50:02 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h0IHo2H0086733;
	Sat, 18 Jan 2003 09:50:02 -0800 (PST)
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 38D5B37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Jan 2003 09:41:23 -0800 (PST)
Received: from bps.jodocus.org (c115139.upc-c.chello.nl [212.187.115.139])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 429A843F1E
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Jan 2003 09:41:15 -0800 (PST)
	(envelope-from joost@bps.jodocus.org)
Received: (from joost@localhost)
	by bps.jodocus.org (8.11.6/8.11.6) id h0IHfBT78680;
	Sat, 18 Jan 2003 18:41:11 +0100 (CET)
	(envelope-from joost)
Message-Id: <200301181741.h0IHfBT78680@bps.jodocus.org>
Date: Sat, 18 Jan 2003 18:41:11 +0100 (CET)
From: Joost Bekkers <joost@bps.jodocus.org>
Reply-To: Joost Bekkers <joost@bps.jodocus.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: misc/47191: 'make iso.1' in /usr/src/release: iso's are not bootable
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         47191
>Category:       misc
>Synopsis:       'make iso.1' in /usr/src/release: iso's are not bootable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 18 09:50:02 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Joost Bekkers
>Release:        FreeBSD 4.5-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD bps.jodocus.org 4.5-RELEASE-p2 FreeBSD 4.5-RELEASE-p2 #1: Wed Aug 7 10:13:09 CEST 2002 joost@bps.jodocus.org:/usr/src/sys/compile/bps i386


>Description:

When you do a 'make iso.1' in /usr/src/release of the chroot-ed environment created
by make release. The iso images it creates are only bootable if you define MAKE_ISOS.
This doesn't seem right to me, because you shouldn't need to tell it twice to make iso's.
(ie 'make iso.1 -DMAKE_ISOS')

>How-To-Repeat:

start a 'make release' and "forget" to include -DMAKE_ISOS
chroot /usr/release (or whatever)
cd /usr/src/release
make iso.1

>Fix:

***************
*** 234,242 ****
  EXTRAS= cdrom.1 ftp.1
  .if defined(MAKE_ISOS)
  EXTRAS+= iso.1
  .if ${TARGET} != "pc98"
  BOOTABLE="-b"
- .endif
  .endif
  
  .if !defined(NODOC)
--- 234,244 ----
  EXTRAS= cdrom.1 ftp.1
  .if defined(MAKE_ISOS)
  EXTRAS+= iso.1
+ .endif
+ #moved out of previous .if to make the iso.1 target work properly when
+ #not 'called' through release
  .if ${TARGET} != "pc98"
  BOOTABLE="-b"
  .endif
  
  .if !defined(NODOC)

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message