From owner-svn-src-head@FreeBSD.ORG  Thu Jul 25 09:29:48 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id D60B1140;
 Thu, 25 Jul 2013 09:29:48 +0000 (UTC) (envelope-from uqs@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C2D0A2AE4;
 Thu, 25 Jul 2013 09:29:48 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r6P9TmI5058349;
 Thu, 25 Jul 2013 09:29:48 GMT (envelope-from uqs@svn.freebsd.org)
Received: (from uqs@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r6P9TmYi058348;
 Thu, 25 Jul 2013 09:29:48 GMT (envelope-from uqs@svn.freebsd.org)
Message-Id: <201307250929.r6P9TmYi058348@svn.freebsd.org>
From: Ulrich Spoerlein <uqs@FreeBSD.org>
Date: Thu, 25 Jul 2013 09:29:48 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r253645 - head/sys/dev/sound/pci
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jul 2013 09:29:48 -0000

Author: uqs
Date: Thu Jul 25 09:29:48 2013
New Revision: 253645
URL: http://svnweb.freebsd.org/changeset/base/253645

Log:
  snd_ds1(4): Fix order of arguments for stereo/16bit mode
  
  This function is called 4 times in this file, with swapped parameter
  ordering. Fix the function definition instead of all the call sites.
  16bit/stereo or 8bit/mono playback is unaffected and was probably
  working fine before, this should fix 16bit/mono and 8bit/stereo
  playback.
  
  Found by:	Coverity Scan, CID 1006688

Modified:
  head/sys/dev/sound/pci/ds1.c

Modified: head/sys/dev/sound/pci/ds1.c
==============================================================================
--- head/sys/dev/sound/pci/ds1.c	Thu Jul 25 09:12:46 2013	(r253644)
+++ head/sys/dev/sound/pci/ds1.c	Thu Jul 25 09:29:48 2013	(r253645)
@@ -365,7 +365,7 @@ ds_allocpslot(struct sc_info *sc)
 }
 
 static int
-ds_initpbank(volatile struct pbank *pb, int ch, int b16, int stereo, u_int32_t rate, bus_addr_t base, u_int32_t len)
+ds_initpbank(volatile struct pbank *pb, int ch, int stereo, int b16, u_int32_t rate, bus_addr_t base, u_int32_t len)
 {
 	u_int32_t lv[] = {1, 1, 0, 0, 0};
 	u_int32_t rv[] = {1, 0, 1, 0, 0};